]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Remove test that was no longer used for long
authorZhiteng Huang <zhithuang@ebaysf.com>
Fri, 13 Dec 2013 14:20:47 +0000 (22:20 +0800)
committerZhiteng Huang <zhithuang@ebaysf.com>
Fri, 13 Dec 2013 14:25:08 +0000 (22:25 +0800)
test_too_big_volume() case in test_volume.py was legacy from nova-
volume, it was never actually testing anything.  This change removes
this case for good.

Change-Id: I66e0eb80326f039ddc580dec0409fd4090ba5102

cinder/tests/test_volume.py

index 6109c2f8313f2dc76189eb0487869d3027918223..37bc3684957c91aa5d84cd7ace68da419d9c3c69 100644 (file)
@@ -841,20 +841,6 @@ class VolumeTestCase(BaseVolumeTestCase):
                           image_id='fake_id',
                           source_volume='fake_id')
 
-    def test_too_big_volume(self):
-        """Ensure failure if a too large of a volume is requested."""
-        # FIXME(vish): validation needs to move into the data layer in
-        #              volume_create
-        return True
-        try:
-            volume = tests_utils.create_volume(self.context, size=1001,
-                                               status='creating',
-                                               host=CONF.host)
-            self.volume.create_volume(self.context, volume)
-            self.fail("Should have thrown TypeError")
-        except TypeError:
-            pass
-
     def test_run_attach_detach_volume_for_instance(self):
         """Make sure volume can be attached and detached from instance."""
         mountpoint = "/dev/sdf"