]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fixes bulk insertion of data to ml2_port_binding
authoryuyangbj <yangyu@vmware.com>
Wed, 13 May 2015 06:07:36 +0000 (14:07 +0800)
committerZhenmei <zma@vmware.com>
Mon, 8 Jun 2015 21:56:57 +0000 (05:56 +0800)
We should use schema definition to insert bulk of data to table.
Closes-Bug: #1454566

Change-Id: I66b3ee8c2f9fa6f04b9e89dc49d1a3d277d63191

neutron/db/migration/alembic_migrations/versions/2b801560a332_remove_hypervneutronplugin_tables.py

index 31515849956edb984b1c58f27c5e43eef5c9b418..711ebe05e3ecaadfa2ab23aedf0181b17ccc1f16 100644 (file)
@@ -32,6 +32,7 @@ revision = '2b801560a332'
 down_revision = '2d2a8a565438'
 
 from alembic import op
+import sqlalchemy as sa
 from sqlalchemy.sql import expression as sa_expr
 
 from neutron.extensions import portbindings
@@ -119,8 +120,9 @@ def _migrate_port_bindings(engine):
         if segment:
             binding['segment'] = segment
     if ml2_bindings:
-        ml2_port_bindings = sa_expr.table('ml2_port_bindings')
-        op.execute(ml2_port_bindings.insert(), ml2_bindings)
+        md = sa.MetaData()
+        sa.Table('ml2_port_bindings', md, autoload=True, autoload_with=engine)
+        op.bulk_insert(md.tables['ml2_port_bindings'], ml2_bindings)
 
 
 def upgrade():