]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Merge "l2-pop : removing a TODO for the delete port use case"
authorJenkins <jenkins@review.openstack.org>
Wed, 16 Jul 2014 07:04:31 +0000 (07:04 +0000)
committerGerrit Code Review <review@openstack.org>
Wed, 16 Jul 2014 07:04:31 +0000 (07:04 +0000)
1  2 
neutron/plugins/ml2/drivers/l2pop/mech_driver.py

index af4a427fcfac196fb7358d1a7a8f513187249fd8,faa75256acc23006b1749d4814dbf7beced2a16d..531dd5ee33f303df6e690f3b63174cfcb0a0d307
@@@ -48,19 -43,10 +47,10 @@@ class L2populationMechanismDriver(api.M
          return [[port['mac_address'],
                   ip['ip_address']] for ip in port['fixed_ips']]
  
-     def delete_port_precommit(self, context):
-         # TODO(matrohon): revisit once the original bound segment will be
-         # available in delete_port_postcommit. in delete_port_postcommit
-         # agent_active_ports will be equal to 0, and the _update_port_down
-         # won't need agent_active_ports_count_for_flooding anymore
-         port_context = context.current
-         fdb_entries = self._update_port_down(context, port_context, 1)
-         self.deleted_ports[context.current['id']] = fdb_entries
      def delete_port_postcommit(self, context):
-         fanout_msg = self.deleted_ports.pop(context.current['id'], None)
+         fanout_msg = self._update_port_down(context, context.current)
          if fanout_msg:
 -            l2pop_rpc.L2populationAgentNotify.remove_fdb_entries(
 +            self.L2populationAgentNotify.remove_fdb_entries(
                  self.rpc_ctx, fanout_msg)
  
      def _get_diff_ips(self, orig, port):
          # Notify other agents to add fdb rule for current port
          other_fdb_entries[network_id]['ports'][agent_ip] += port_fdb_entries
  
 -        l2pop_rpc.L2populationAgentNotify.add_fdb_entries(self.rpc_ctx,
 -                                                          other_fdb_entries)
 +        self.L2populationAgentNotify.add_fdb_entries(self.rpc_ctx,
 +                                                     other_fdb_entries)
  
-     def _update_port_down(self, context, port_context,
-                           agent_active_ports_count_for_flooding=0):
+     def _update_port_down(self, context, port_context):
          port_infos = self._get_port_infos(context, port_context)
          if not port_infos:
              return