]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
drop mock dependency
authorEmilien Macchi <emilien@redhat.com>
Fri, 22 Jan 2016 14:31:14 +0000 (09:31 -0500)
committerEmilien Macchi <emilien@redhat.com>
Fri, 22 Jan 2016 14:31:14 +0000 (09:31 -0500)
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636

Change-Id: I000953c7b215454baf9838813c04e94b7ebeca00

Gemfile
spec/classes/ceilometer_collector_spec.rb
spec/spec_helper.rb

diff --git a/Gemfile b/Gemfile
index 5ad0760ce657c30967ef8d5659136e8c187ae708..efeba2a44670a4b673ed2e0649ac0c6be6579e15 100644 (file)
--- a/Gemfile
+++ b/Gemfile
@@ -14,7 +14,6 @@ group :development, :test do
   gem 'puppet-lint-variable_contains_upcase', :require => 'false'
   gem 'puppet-lint-numericvariable',          :require => 'false'
   gem 'json',                                 :require => 'false'
-  gem 'webmock',                              :require => 'false'
   gem 'puppet-openstack_spec_helper',
       :git => 'https://git.openstack.org/openstack/puppet-openstack_spec_helper',
       :require => false
index b1752f7af6e60ec50a2bb148e9a0273769458dd1..a7b8fe6a2b5db187409a3a44b29bb555b1c29c2f 100644 (file)
@@ -1,6 +1,4 @@
 require 'spec_helper'
-# LP1492636 - Cohabitation of compile matcher and webmock
-WebMock.disable_net_connect!(:allow => "169.254.169.254")
 
 describe 'ceilometer::collector' do
 
index bd97904b9c66f14c1f5de98e63396cb25dd356f4..be3811cf229bc4252b16c21803646cbccd89027a 100644 (file)
@@ -1,6 +1,5 @@
 require 'puppetlabs_spec_helper/module_spec_helper'
 require 'shared_examples'
-require 'webmock/rspec'
 
 require 'puppet-openstack_spec_helper/defaults'
 require 'rspec-puppet-facts'