]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Add debug message for lvremove after udev settle
authorJohn Griffith <john.griffith@solidfire.com>
Wed, 28 Jan 2015 04:20:38 +0000 (22:20 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Wed, 28 Jan 2015 16:09:32 +0000 (10:09 -0600)
Just add a simple debug level log message for lvremove calls that
are made and successfully completed as part of error recovery.

Currently some platforms commonly receive a "Unable to deactivate"
error message when running an lvremove.  We have a retry mechanism
that performs a udevsettle and retries that in most cases results
in a succesful removal.

This patch just adds an explicit debug log message so we can track
this more easily and gather some statistical data on it.

Change-Id: I8f2480491f3cb7f078597113f967c1e285fdf105

cinder/brick/local_dev/lvm.py

index 9776ddf2e315e2a1df13d8b99947216e941ebc5a..bba753bf9f27c15302c757fb771f39017f563433 100644 (file)
@@ -626,6 +626,8 @@ class LVM(executor.Executor):
                 '-f',
                 '%s/%s' % (self.vg_name, name),
                 root_helper=self._root_helper, run_as_root=True)
+            LOG.debug('Successfully deleted volume: %s after '
+                      'udev settle.', name)
 
     def revert(self, snapshot_name):
         """Revert an LV from snapshot.