]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
ReST API: Improve format of resource_types response
authorZane Bitter <zbitter@redhat.com>
Wed, 19 Dec 2012 17:48:25 +0000 (18:48 +0100)
committerZane Bitter <zbitter@redhat.com>
Wed, 19 Dec 2012 18:51:58 +0000 (19:51 +0100)
Wrap the list in a JSON object for consistency with other APIs, both in
Heat and the rest of OpenStack.

Change-Id: I626f1c2446416c8e869fdc7d4f3772ec6c6d191c
Signed-off-by: Zane Bitter <zbitter@redhat.com>
heat/api/openstack/v1/stacks.py
heat/tests/test_api_openstack_v1.py

index b6d693ec9db95551f4774e392c113f08404c03c3..70894f472747f73602480d3463ce25fba76ebdce 100644 (file)
@@ -316,7 +316,7 @@ class StackController(object):
         except rpc_common.RemoteError as ex:
             raise exc.HTTPInternalServerError(explanation=str(ex))
 
-        return types
+        return {'resource_types': types}
 
 
 def create_resource(options):
index 4511762aaad776ea4c49dd8a0694cefb3709aed3..e65447611f13812a3ab9220cb27bf281bce15c4a 100644 (file)
@@ -809,7 +809,7 @@ class StackControllerTest(ControllerTest, unittest.TestCase):
         self.m.ReplayAll()
         response = self.controller.list_resource_types(req,
                                                        tenant_id=self.tenant)
-        self.assertEqual(response, engine_response)
+        self.assertEqual(response, {'resource_types': engine_response})
         self.m.VerifyAll()
 
     def test_list_resource_types_error(self):