]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Add acceptance tests for config management resources
authorTakashi Kajinami <tkajinam@redhat.com>
Sat, 9 Jul 2022 03:20:10 +0000 (12:20 +0900)
committerTakashi Kajinami <tkajinam@redhat.com>
Sun, 10 Jul 2022 03:36:25 +0000 (12:36 +0900)
Change-Id: Ibf9df166c7262d51ed937d4cf4f3fc30099fa57b

spec/acceptance/10_basic_ceilometer_config_spec.rb [moved from spec/acceptance/ceilometer_wsgi_apache_spec.rb with 100% similarity]
spec/acceptance/99_ceilometer_config_spec.rb [new file with mode: 0644]

diff --git a/spec/acceptance/99_ceilometer_config_spec.rb b/spec/acceptance/99_ceilometer_config_spec.rb
new file mode 100644 (file)
index 0000000..6834157
--- /dev/null
@@ -0,0 +1,95 @@
+require 'spec_helper_acceptance'
+
+describe 'basic ceilometer_config resource' do
+
+  context 'default parameters' do
+
+    it 'should work with no errors' do
+      pp= <<-EOS
+      Exec { logoutput => 'on_failure' }
+
+      File <||> -> Ceilometer_config <||>
+      File <||> -> Ceilometer_rootwrap_config <||>
+
+      file { '/etc/ceilometer' :
+        ensure => directory,
+      }
+      file { '/etc/ceilometer/ceilometer.conf' :
+        ensure => file,
+      }
+      file { '/etc/ceilometer/rootwrap.conf' :
+        ensure => file,
+      }
+
+      ceilometer_config { 'DEFAULT/thisshouldexist' :
+        value => 'foo',
+      }
+
+      ceilometer_config { 'DEFAULT/thisshouldnotexist' :
+        value => '<SERVICE DEFAULT>',
+      }
+
+      ceilometer_config { 'DEFAULT/thisshouldexist2' :
+        value             => '<SERVICE DEFAULT>',
+        ensure_absent_val => 'toto',
+      }
+
+      ceilometer_config { 'DEFAULT/thisshouldexist3' :
+        value => ['foo', 'bar'],
+      }
+
+      ceilometer_config { 'DEFAULT/thisshouldnotexist2' :
+        value             => 'toto',
+        ensure_absent_val => 'toto',
+      }
+
+      ceilometer_rootwrap_config { 'DEFAULT/thisshouldexist' :
+        value => 'foo',
+      }
+
+      ceilometer_rootwrap_config { 'DEFAULT/thisshouldnotexist' :
+        value => '<SERVICE DEFAULT>',
+      }
+
+      ceilometer_rootwrap_config { 'DEFAULT/thisshouldexist2' :
+        value             => '<SERVICE DEFAULT>',
+        ensure_absent_val => 'toto',
+      }
+
+      ceilometer_rootwrap_config { 'DEFAULT/thisshouldnotexist2' :
+        value             => 'toto',
+        ensure_absent_val => 'toto',
+      }
+      EOS
+
+
+      # Run it twice and test for idempotency
+      apply_manifest(pp, :catch_failures => true)
+      apply_manifest(pp, :catch_changes => true)
+    end
+
+    describe file('/etc/ceilometer/ceilometer.conf') do
+      it { is_expected.to exist }
+      it { is_expected.to contain('thisshouldexist=foo') }
+      it { is_expected.to contain('thisshouldexist2=<SERVICE DEFAULT>') }
+      it { is_expected.to contain('thisshouldexist3=foo') }
+      it { is_expected.to contain('thisshouldexist3=bar') }
+
+      describe '#content' do
+        subject { super().content }
+        it { is_expected.to_not match /thisshouldnotexist/ }
+      end
+    end
+
+    describe file('/etc/ceilometer/rootwrap.conf') do
+      it { is_expected.to exist }
+      it { is_expected.to contain('thisshouldexist=foo') }
+      it { is_expected.to contain('thisshouldexist2=<SERVICE DEFAULT>') }
+
+      describe '#content' do
+        subject { super().content }
+        it { is_expected.to_not match /thisshouldnotexist/ }
+      end
+    end
+  end
+end