]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Ml2: Set correct nullable for admin_state_up
authorAnn Kamyshnikova <akamyshnikova@mirantis.com>
Tue, 22 Apr 2014 07:22:24 +0000 (11:22 +0400)
committerAnn Kamyshnikova <akamyshnikova@mirantis.com>
Tue, 22 Apr 2014 12:05:08 +0000 (16:05 +0400)
In migrations 492a106273f8_brocade_ml2_mech_dri was set incorrect
nullable parameter:

Set admin_state_up NOT NULL in ml2_brocadeports.

Partial-Bug: #1296282

Change-Id: I051e37990ae3371978eeb1ff71e70ae2a44097bc

neutron/db/migration/alembic_migrations/versions/HEAD
neutron/db/migration/alembic_migrations/versions/d06e871c0d5_set_admin_state_up_not_null_ml2.py [new file with mode: 0644]

index a15d5c34c0fcc42cf00ee6612ed873c392655634..2ca3173591a511a69824a8f122c260c2508dd9ba 100644 (file)
@@ -1 +1 @@
-4eca4a84f08a
+d06e871c0d5
diff --git a/neutron/db/migration/alembic_migrations/versions/d06e871c0d5_set_admin_state_up_not_null_ml2.py b/neutron/db/migration/alembic_migrations/versions/d06e871c0d5_set_admin_state_up_not_null_ml2.py
new file mode 100644 (file)
index 0000000..be99747
--- /dev/null
@@ -0,0 +1,54 @@
+# Copyright 2014 OpenStack Foundation
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+#
+
+"""set_admin_state_up_not_null_ml2
+
+Revision ID: d06e871c0d5
+Revises: 2447ad0e9585
+Create Date: 2014-03-21 17:22:20.545186
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = 'd06e871c0d5'
+down_revision = '4eca4a84f08a'
+
+# Change to ['*'] if this migration applies to all plugins
+
+migration_for_plugins = [
+    'neutron.plugins.ml2.plugin.Ml2Plugin'
+]
+
+from alembic import op
+import sqlalchemy as sa
+
+
+from neutron.db import migration
+
+
+def upgrade(active_plugins=None, options=None):
+    if not migration.should_run(active_plugins, migration_for_plugins):
+        return
+
+    op.alter_column('ml2_brocadeports', 'admin_state_up', nullable=False,
+                    existing_type=sa.Boolean)
+
+
+def downgrade(active_plugins=None, options=None):
+    if not migration.should_run(active_plugins, migration_for_plugins):
+        return
+
+    op.alter_column('ml2_brocadeports', 'admin_state_up', nullable=True,
+                    existing_type=sa.Boolean)