]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Finish moving Keystone Auth from init.pp to api.pp
authorFrançois Charlier <fcharlier@ploup.net>
Mon, 10 Dec 2012 14:58:20 +0000 (15:58 +0100)
committerFrançois Charlier <fcharlier@ploup.net>
Mon, 10 Dec 2012 14:58:50 +0000 (15:58 +0100)
manifests/api.pp
manifests/init.pp

index 2db8dd9b924ad03e7d0c94305fc2948f2cafbfb9..1751a38c7ad7c898bc7ae96390a91ad2231cee37 100644 (file)
@@ -4,9 +4,12 @@ class ceilometer::api(
   $keystone_port = '35357',
   $keystone_protocol = 'http',
   $keystone_user = 'ceilometer',
-  $keystone_password,
+  $keystone_password = undef,
 ) {
 
+
+  validate_string($keystone_password)
+
   package { 'ceilometer-api':
     ensure => installed
   }
@@ -18,11 +21,17 @@ class ceilometer::api(
   }
 
   service { 'ceilometer-api':
-    name       => $::ceilometer::params::api_service_name
-    enable      => $enabled,
+    name       => $::ceilometer::params::api_service_name,
+    enable     => $enabled,
     hasstatus  => true,
     hasrestart => true,
-    require => Package['ceilometer-api']
+    require    => Package['ceilometer-api']
+  }
+
+  ceilometer_setting {
+    'keystone_authtoken/auth_host': value => $keystone_host;
+    'keystone_authtoken/auth_port': value => $keystone_port;
+    'keystone_authtoken/protocol': value => $keystone_protocol;
   }
 
 }
index c78e40fd92d28010db60f0bf8ac4a40e5bde4fa5..7bd19ccccc567c50d71a3668218bb85cf35f0b76 100644 (file)
@@ -35,8 +35,8 @@ class ceilometer(
   }
 
   package { 'ceilometer-common':
-    name   => $::ceilometer::params::common_package_name,
     ensure => $package_ensure,
+    name   => $::ceilometer::params::common_package_name,
   }
 
   ceilometer_setting {
@@ -48,9 +48,6 @@ class ceilometer(
     'DEFAULT/debug': value => $debug;
     'DEFAULT/verbose': value => $verbose;
     'DEFAULT/database_connection': value => $database_connection;
-    'keystone_authtoken/auth_host': value => $keystone_host;
-    'keystone_authtoken/auth_port': value => $keystone_port;
-    'keystone_authtoken/protocol': value => $keystone_protocol;
   }