]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Deprecate support for Fedora 18
authorLukas Bezdicka <lbezdick@redhat.com>
Fri, 19 Dec 2014 12:04:04 +0000 (13:04 +0100)
committerLukas Bezdicka <lbezdick@redhat.com>
Mon, 12 Jan 2015 17:19:01 +0000 (18:19 +0100)
Also fixes error on Rawhide: Error: comparison of String with 18.
Package python-sqlite2 is deprecated since F18. F19 is also EOL.
https://fedoraproject.org/wiki/End_of_life

Change-Id: Id59fd02af92c6d77d49195001fc4f983d66d29dd

manifests/params.pp
spec/classes/ceilometer_db_spec.rb

index b91ef5777090adf0f8e69e3da1ab49e43a57b2d5..1d34bd2c8a62e3364d9750fc6771da6a56b4fa77 100644 (file)
@@ -27,18 +27,9 @@ class ceilometer::params {
       $pymongo_package_name            = 'python-pymongo'
       $psycopg_package_name            = 'python-psycopg2'
       $agent_notification_service_name = 'openstack-ceilometer-notification'
-
-      # db packages
-      if $::operatingsystem == 'Fedora' and $::operatingsystemrelease >= 18 {
-        # fallback to stdlib version, not provided on fedora
-        $sqlite_package_name      = undef
-      } else {
-        $sqlite_package_name      = 'python-sqlite2'
-      }
-
-      $ceilometer_wsgi_script_path    = '/var/www/cgi-bin/ceilometer'
-      $ceilometer_wsgi_script_source  = '/usr/lib/python2.7/site-packages/ceilometer/api/app.wsgi'
-
+      $ceilometer_wsgi_script_path     = '/var/www/cgi-bin/ceilometer'
+      $ceilometer_wsgi_script_source   = '/usr/lib/python2.7/site-packages/ceilometer/api/app.wsgi'
+      $sqlite_package_name             = undef
     }
     'Debian': {
       # package names
index f6526584e15b2c6067c1528d7d020cdec7fa5f4a..8ba949280aac54d7cdea393f8a993342c02ddd76 100644 (file)
@@ -34,12 +34,11 @@ describe 'ceilometer::db' do
     end
   end
 
-  # Fedora > 18 has python-pymongo too
   context 'on Redhat platforms' do
     let :facts do
       { :osfamily => 'Redhat',
         :operatingsystem => 'Fedora',
-        :operatingsystemrelease => 18
+        :operatingsystemrelease => 21
       }
     end
 
@@ -119,9 +118,6 @@ describe 'ceilometer::db' do
     it { should contain_class('ceilometer::params') }
 
     it 'installs pymongo package' do
-      should contain_package('ceilometer-backend-package').with(
-        :ensure => 'present',
-        :name => 'python-sqlite2')
       should contain_ceilometer_config('database/connection').with_value('sqlite:///var/lib/ceilometer.db')
       should contain_ceilometer_config('database/connection').with_value( params[:database_connection] ).with_secret(true)
     end