]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Code Review / openstack-build / cinder-build.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 36e4e85)
Fix Storwize/SVC LUN allocation with holes.
authorAvishay Traeger <avishay@il.ibm.com>
Tue, 19 Mar 2013 07:42:06 +0000 (09:42 +0200)
committerJohn Griffith <john.griffith@solidfire.com>
Fri, 22 Mar 2013 03:57:56 +0000 (21:57 -0600)
The Storwize/SVC driver should find the first unused LUN, but
continues searching, returning erroneous results.  Added 'break'
statement to fix.

Change-Id: Ibd95714e086a513a39fe9d20ffec57135dc5ec55
Fixes: bug 1157012
(cherry picked from commit e0878c86207d5ff5c2ebaa69eac454af545925ef)

cinder/volume/drivers/storwize_svc.py patch | blob | history

diff --git a/cinder/volume/drivers/storwize_svc.py b/cinder/volume/drivers/storwize_svc.py
index 8d72b6f297cba51f084762358aabb3b655ebab07..65c7e771a443b619b808c18e80e736a13253b817 100644 (file)
--- a/cinder/volume/drivers/storwize_svc.py
+++ b/cinder/volume/drivers/storwize_svc.py
@@ -593,6 +593,7 @@ class StorwizeSVCDriver(san.SanISCSIDriver):
             for index, n in enumerate(lun_used):
                 if n > index:
                     result_lun = str(index)
+                    break
 
         # Volume is not mapped to host, create a new LUN
         if not mapped_flag: