]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Remove an unnecessary extension check for rbac
authorKevin Benton <blak111@gmail.com>
Fri, 4 Sep 2015 11:28:58 +0000 (04:28 -0700)
committerKevin Benton <blak111@gmail.com>
Fri, 4 Sep 2015 12:18:18 +0000 (05:18 -0700)
This removes some logic to detect the RBAC extension
that was written when RBAC was being developed as a
service plugin. Since it's part of db base plugin there
is nothing to enable in devstack so it's not necessary.

Change-Id: I37f8060c14d8ad74f5cea649c18ee9ef3912cb2d

neutron/tests/api/admin/test_shared_network_extension.py

index 78215e417044cdfe216095fead78cbd9141dae91..b60ebf9a94966dac45f2d02b83b24901a0694f6b 100644 (file)
@@ -182,18 +182,9 @@ class RBACSharedNetworksTest(base.BaseAdminNetworkTest):
     @classmethod
     def resource_setup(cls):
         super(RBACSharedNetworksTest, cls).resource_setup()
-        extensions = cls.admin_client.list_extensions()
         if not test.is_extension_enabled('rbac_policies', 'network'):
             msg = "rbac extension not enabled."
             raise cls.skipException(msg)
-        # NOTE(kevinbenton): the following test seems to be necessary
-        # since the default is 'all' for the above check and these tests
-        # need to get into the gate and be disabled until the service plugin
-        # is enabled in devstack. Is there a better way to do this?
-        if 'rbac-policies' not in [x['alias']
-                                   for x in extensions['extensions']]:
-            msg = "rbac extension is not in extension listing."
-            raise cls.skipException(msg)
         creds = cls.isolated_creds.get_alt_creds()
         cls.client2 = clients.Manager(credentials=creds).network_client