]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix pep8 issues
authorGary Kotton <gkotton@redhat.com>
Wed, 19 Dec 2012 06:57:36 +0000 (06:57 +0000)
committerGary Kotton <gkotton@redhat.com>
Wed, 19 Dec 2012 06:57:56 +0000 (06:57 +0000)
Change-Id: I62674220028274619a9b180542eea716f2660917

quantum/plugins/cisco/models/network_multi_blade_v2.py
quantum/plugins/cisco/models/virt_phy_sw_v2.py
quantum/tests/unit/test_attributes.py
quantum/tests/unit/test_debug_commands.py
quantum/tests/unit/test_linux_ip_lib.py

index 6a50121c0091c2f62284cedf3d88a655eb9da1b8..1f55bfdcd1da21de64e16886914e0275c8819762 100644 (file)
@@ -180,8 +180,8 @@ class NetworkMultiBladeV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
             base_plugin_ref = kwargs[const.BASE_PLUGIN_REF]
             n = kwargs[const.NETWORK]
             tenant_id = n['tenant_id']
-            args = [tenant_id, id, {const.CONTEXT:context},
-                    {const.BASE_PLUGIN_REF:base_plugin_ref}]
+            args = [tenant_id, id, {const.CONTEXT: context},
+                    {const.BASE_PLUGIN_REF: base_plugin_ref}]
             # TODO (Sumit): Might first need to check here if there are active
             # ports
             output = []
index 1d6622e5e0d90d777386a02dd185e459b1209860..d77527f26558123020fcc523648ccc94f7d9bbdf 100644 (file)
@@ -200,7 +200,7 @@ class VirtualPhysicalSwitchModelV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
             vlanids = self._get_all_segmentation_ids()
             args = [ovs_output[0]['tenant_id'], ovs_output[0]['name'],
                     ovs_output[0]['id'], vlan_name, vlan_id,
-                    {'vlan_ids':vlanids}]
+                    {'vlan_ids': vlanids}]
             nexus_output = self._invoke_plugin_per_device(const.NEXUS_PLUGIN,
                                                           self._func_name(),
                                                           args)
@@ -227,7 +227,7 @@ class VirtualPhysicalSwitchModelV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
                 vlan_name = conf.VLAN_NAME_PREFIX + str(vlan_id)
                 args = [ovs_network['tenant_id'], ovs_network['name'],
                         ovs_network['id'], vlan_name, vlan_id,
-                        {'vlan_ids':vlanids}]
+                        {'vlan_ids': vlanids}]
                 nexus_output = self._invoke_plugin_per_device(
                     const.NEXUS_PLUGIN, "create_network", args)
             return ovs_output
@@ -271,9 +271,9 @@ class VirtualPhysicalSwitchModelV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
             ovs_output = self._invoke_plugin_per_device(const.VSWITCH_PLUGIN,
                                                         self._func_name(),
                                                         args)
-            args = [tenant_id, id, {const.VLANID:vlan_id},
-                    {const.CONTEXT:context},
-                    {const.BASE_PLUGIN_REF:base_plugin_ref}]
+            args = [tenant_id, id, {const.VLANID: vlan_id},
+                    {const.CONTEXT: context},
+                    {const.BASE_PLUGIN_REF: base_plugin_ref}]
             if self._validate_vlan_id(vlan_id):
                 self._invoke_plugin_per_device(const.NEXUS_PLUGIN,
                                                self._func_name(), args)
index 447cbf6478cf159429085664e779bb3da9a8a17c..8b470b9009143174ca451e4da257db614b7c6320 100644 (file)
@@ -421,7 +421,7 @@ class TestConvertToInt(unittest2.TestCase):
             [], attributes.convert_none_to_empty_list(None))
 
     def test_convert_none_to_empty_list_value(self):
-        values = ['1', 3, [], [1], {}, {'a':3}]
+        values = ['1', 3, [], [1], {}, {'a': 3}]
         for value in values:
             self.assertEqual(
                 value, attributes.convert_none_to_empty_list(value))
index 1a8fe9295e1f76bf031ba7d2b369a005151d46f0..29276623514237b1b8ada5ba90edbf7e28a1e6ff 100644 (file)
@@ -77,7 +77,7 @@ class TestDebugCommands(unittest.TestCase):
                      'mac_address': 'aa:bb:cc:dd:ee:ffa',
                      'network_id': 'fake_net',
                      'fixed_ips':
-                     [{'subnet_id': 'fake_subnet', 'ip_address':'10.0.0.3'}]
+                     [{'subnet_id': 'fake_subnet', 'ip_address': '10.0.0.3'}]
                      }}
         fake_ports = {'ports': [fake_port['port']]}
         self.fake_ports = fake_ports
index b3ed926e437f67a8d7bfdcd994e58ca5f94b3076..23e37be7e5b08d4abff97811d374be1e93cb2a40 100644 (file)
@@ -536,10 +536,10 @@ class TestIpRouteCommand(TestIPCmdBase):
 
     def test_get_gateway(self):
         test_cases = [{'sample': GATEWAY_SAMPLE1,
-                       'expected': {'gateway':'10.35.19.254',
+                       'expected': {'gateway': '10.35.19.254',
                                     'metric': 100}},
                       {'sample': GATEWAY_SAMPLE2,
-                       'expected': {'gateway':'10.35.19.254',
+                       'expected': {'gateway': '10.35.19.254',
                                     'metric': 100}},
                       {'sample': GATEWAY_SAMPLE3,
                        'expected': None},