]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Should've added super().tearDown() in test_iscsi
authorJohn Griffith <john.griffith@solidfire.com>
Thu, 13 Sep 2012 14:50:09 +0000 (08:50 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Thu, 13 Sep 2012 14:52:25 +0000 (08:52 -0600)
  Made changes to use tempfiles and implemented teardown,
  but should have also called super().tearDown as well.

  Associated with chage: I9b9a2400

Change-Id: I2e9d1cb7bfbe78323630eb2f3270698a7ce7e4c4

cinder/tests/test_iscsi.py

index 362ddf0b7e83465124a4940ef37ae3e3ee942d7a..32a1309dd7160096936223cd8ed5c83b053c0f15 100644 (file)
@@ -104,6 +104,7 @@ class TgtAdmTestCase(test.TestCase, TargetAdminTestCase):
             shutil.rmtree(self.persist_tempdir)
         except OSError:
             pass
+        super(TgtAdmTestCase, self).tearDown()
 
 
 class IetAdmTestCase(test.TestCase, TargetAdminTestCase):