]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Clean up QoSSpecManageApiTest setup
authorSean McGinnis <sean_mcginnis@dell.com>
Fri, 9 Jan 2015 15:42:48 +0000 (09:42 -0600)
committerSean McGinnis <sean_mcginnis@dell.com>
Fri, 9 Jan 2015 15:42:48 +0000 (09:42 -0600)
There is currently unnecessary work being performed in setUp
for QoSSpecManageApiTest and confusing comments. This cleans
that up to avoid confusion.

Test was explicitly calling a reset on a fake, but the cleanup
for each test will do this as well. Relatively harmless, but
this makes the code cleaner.

Change-Id: I2671fc0a186acb75767d9adb1edeb9ad705fc958

cinder/tests/api/contrib/test_qos_specs_manage.py

index f7fe5e68b8c5eb243601ff0b4a874759c88310c3..23db1da2eb1844ddd7d99f3f641784e14183bb01 100644 (file)
@@ -145,10 +145,7 @@ class QoSSpecManageApiTest(test.TestCase):
         self.flags(host='fake')
         self.controller = qos_specs_manage.QoSSpecsController()
 
-        #reset notifier drivers left over from other api/contrib tests
-        # NOTE(flaper87) WTF? ^^^^ Cleanups should happen in each test,
-        # not the purpose of this patch, though.
-        fake_notifier.reset()
+        # Reset notifications for each test
         self.addCleanup(fake_notifier.reset)
 
     def test_index(self):