]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
allow iptables package to be updated
authorCristian Falcas <falcas@optymyze.com>
Wed, 25 Nov 2015 12:26:10 +0000 (14:26 +0200)
committerCristian Falcas <cristi.falcas@gmail.com>
Wed, 3 Feb 2016 12:36:51 +0000 (14:36 +0200)
manifests/init.pp
manifests/linux.pp
manifests/linux/archlinux.pp
manifests/linux/debian.pp
manifests/linux/gentoo.pp
manifests/linux/redhat.pp
manifests/params.pp

index 97ed27312ed697df38f59cd618eb896e117d9e5d..56c8091cd22b8a6fb9a4ef594d964871de1294ef 100644 (file)
@@ -13,6 +13,7 @@
 #
 class firewall (
   $ensure       = running,
+  $pkg_ensure   = present,
   $service_name = $::firewall::params::service_name,
   $package_name = $::firewall::params::package_name,
 ) inherits ::firewall::params {
@@ -29,6 +30,7 @@ class firewall (
     'Linux': {
       class { "${title}::linux":
         ensure       => $ensure,
+        pkg_ensure   => $pkg_ensure,
         service_name => $service_name,
         package_name => $package_name,
       }
index e3f5129b691b6bf84fe02381f1fafaf1c006d995..4769516c153bcac4d78fa23eb50fdc2e219da058 100644 (file)
@@ -13,6 +13,7 @@
 #
 class firewall::linux (
   $ensure       = running,
+  $pkg_ensure   = present,
   $service_name = $::firewall::params::service_name,
   $package_name = $::firewall::params::package_name,
 ) inherits ::firewall::params {
@@ -22,7 +23,7 @@ class firewall::linux (
   }
 
   package { 'iptables':
-    ensure => present,
+    ensure => $pkg_ensure,
   }
 
   case $::operatingsystem {
index cfe1a691a4dbddb901018a9365c2af9b7cbbcd82..bdd803bf0af823840c95ecd6b79b4e29b1fa2389 100644 (file)
 #   Default: true
 #
 class firewall::linux::archlinux (
-  $ensure       = 'running',
-  $enable       = true,
-  $service_name = $::firewall::params::service_name,
-  $package_name = $::firewall::params::package_name,
+  $ensure         = 'running',
+  $enable         = true,
+  $service_name   = $::firewall::params::service_name,
+  $package_name   = $::firewall::params::package_name,
+  $package_ensure = $::firewall::params::package_ensure,
 ) inherits ::firewall::params {
   if $package_name {
     package { $package_name:
-      ensure => $ensure,
+      ensure => $package_ensure,
     }
   }
 
index a24d3ab1640b4c642c7995a3743c882a5d6fc3dc..a857177495e484e71f7c4a83bf11c66ebd3d6f10 100644 (file)
 #   Default: true
 #
 class firewall::linux::debian (
-  $ensure       = running,
-  $enable       = true,
-  $service_name = $::firewall::params::service_name,
-  $package_name = $::firewall::params::package_name,
+  $ensure         = running,
+  $enable         = true,
+  $service_name   = $::firewall::params::service_name,
+  $package_name   = $::firewall::params::package_name,
+  $package_ensure = $::firewall::params::package_ensure,
 ) inherits ::firewall::params {
 
   if $package_name {
@@ -27,7 +28,7 @@ class firewall::linux::debian (
         refreshonly => true
     }
     package { $package_name:
-      ensure  => present,
+      ensure  => $package_ensure,
       require => Exec['iptables-persistent-debconf']
     }
   }
index 29a57cbf8a6569406b5d9edeeb5fba25b6d08159..920e60ccf3b83877b0af2b4c569ff64c35bcbe15 100644 (file)
 #   Default: true
 #
 class firewall::linux::gentoo (
-  $ensure       = 'running',
-  $enable       = true,
-  $service_name = $::firewall::params::service_name,
-  $package_name = $::firewall::params::package_name,
+  $ensure         = 'running',
+  $enable         = true,
+  $service_name   = $::firewall::params::service_name,
+  $package_name   = $::firewall::params::package_name,
+  $package_ensure = $::firewall::params::package_ensure,
 ) inherits ::firewall::params {
   if $package_name {
     package { $package_name:
-      ensure => present,
+      ensure => $package_ensure,
     }
   }
 
index 680c04b139dc469e5093001dbd79a21be36f29e0..44ced37b72c6248f5a15cccf04bfb0686e8a8c3a 100644 (file)
 #   Default: true
 #
 class firewall::linux::redhat (
-  $ensure       = running,
-  $enable       = true,
-  $service_name = $::firewall::params::service_name,
-  $package_name = $::firewall::params::package_name,
+  $ensure         = running,
+  $enable         = true,
+  $service_name   = $::firewall::params::service_name,
+  $package_name   = $::firewall::params::package_name,
+  $package_ensure = $::firewall::params::package_ensure,
 ) inherits ::firewall::params {
 
   # RHEL 7 and later and Fedora 15 and later require the iptables-services
@@ -34,7 +35,7 @@ class firewall::linux::redhat (
 
   if $package_name {
     package { $package_name:
-      ensure => present,
+      ensure => $package_ensure,
       before => Service[$service_name],
     }
   }
index 1e926e7a45ec73e44137be701aeced85060e67cd..a988f01bacca25e3fc9b5754af98352b278c2ad2 100644 (file)
@@ -1,4 +1,5 @@
 class firewall::params {
+  $package_ensure = 'present'
   case $::osfamily {
     'RedHat': {
       case $::operatingsystem {