Enable super-on-old-class pylint check

.. and disable the check locally for two midonet and Ryu classes that
fail since the midonet/ryu libraries are unavailable in our toxenv.

Change-Id: Idca46f853e6a116e8b2c246b4c6cae159894f887

diff --git a/.pylintrc b/.pylintrc
index ad9c8211bc8f39083c928d2bfa4cc8740682f591..d44dee4f83bc04b8a66f0b21ab51b559364e0efc 100644 (file)
--- a/.pylintrc
+++ b/.pylintrc
@@ -25,7 +25,6 @@ disable=
  no-method-argument,
  no-self-argument,
  no-value-for-parameter,
- super-on-old-class,
 # "W" Warnings for stylistic problems or minor programming issues
  abstract-method,
  arguments-differ,

diff --git a/neutron/plugins/midonet/plugin.py b/neutron/plugins/midonet/plugin.py
index 67d46d01924dc38a8cf2f30a73860e0c7d2b8589..d310a51c3182a67baebb297120e7610e47e1ec23 100644 (file)
--- a/neutron/plugins/midonet/plugin.py
+++ b/neutron/plugins/midonet/plugin.py
@@ -36,6 +36,9 @@ midonet_opts = [
 cfg.CONF.register_opts(midonet_opts, "MIDONET")
 
 
+# Derives from `object` (via at least NeutronDbPluginV2), but pylint
+# can't see that without having the midonet libraries available.
+# pylint: disable=super-on-old-class
 class MidonetPluginV2(plugin.MidonetMixin):
 
     vendor_extensions = plugin.MidonetMixin.supported_extension_aliases

diff --git a/neutron/plugins/ofagent/agent/ofa_neutron_agent.py b/neutron/plugins/ofagent/agent/ofa_neutron_agent.py
index dc1a5256ffeefca7feb7c4191ee6d53f1bee554c..af6977cf6ea489645b7db3337b74e7e039a88487 100644 (file)
--- a/neutron/plugins/ofagent/agent/ofa_neutron_agent.py
+++ b/neutron/plugins/ofagent/agent/ofa_neutron_agent.py
@@ -123,6 +123,9 @@ class Bridge(flows.OFAgentIntegrationBridge, ovs_lib.OVSBridge):
         self.get_datapath(retry_max)
 
 
+# RyuApp derives from `object`, but pylint can't see that without
+# having the ryu libraries available.
+# pylint: disable=super-on-old-class
 class OFANeutronAgentRyuApp(app_manager.RyuApp):
     OFP_VERSIONS = [ryu_ofp13.OFP_VERSION]