hacking: Fix false positive in C302 check

Use a regular expression to search for "unicode(" instead of a static
string to not complain to "exception_to_unicode(error)".

Change-Id: I0a969b184054f287cef463bbcb980bfb4a0a6803

diff --git a/cinder/hacking/checks.py b/cinder/hacking/checks.py
index 52ff7b7bf4506755591bf6b6e1e3f5eb47683fd0..7652ae655a8a2ecba9b44df2b23fa6279dbd196b 100644 (file)
--- a/cinder/hacking/checks.py
+++ b/cinder/hacking/checks.py
@@ -400,13 +400,16 @@ def check_datetime_now(logical_line, noqa):
         yield(0, msg)
 
 
+_UNICODE_USAGE_REGEX = re.compile(r'\bunicode *\(')
+
+
 def check_unicode_usage(logical_line, noqa):
     if noqa:
         return
 
     msg = "C302: Found unicode() call. Please use six.text_type()."
 
-    if 'unicode(' in logical_line:
+    if _UNICODE_USAGE_REGEX.search(logical_line):
         yield(0, msg)