]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix confusing parameters names
authorOleg Bondarev <obondarev@mirantis.com>
Wed, 3 Jun 2015 12:38:50 +0000 (15:38 +0300)
committerOleg Bondarev <obondarev@mirantis.com>
Wed, 3 Jun 2015 12:38:50 +0000 (15:38 +0300)
Change-Id: Ib00135e1d0b8f334d660de9a80629e084efb13ba

neutron/db/securitygroups_db.py

index f3572fd10ad427f8179ecec15eac9c3a75ed44cc..1fec3f2239bb4c4b711c4f711f14ddcc053ce8a8 100644 (file)
@@ -342,9 +342,9 @@ class SecurityGroupDbMixin(ext_sg.SecurityGroupPluginBase):
             for binding in bindings:
                 context.session.delete(binding)
 
-    def create_security_group_rule_bulk(self, context, security_group_rule):
+    def create_security_group_rule_bulk(self, context, security_group_rules):
         return self._create_bulk('security_group_rule', context,
-                                 security_group_rule)
+                                 security_group_rules)
 
     def create_security_group_rule_bulk_native(self, context,
                                                security_group_rule):
@@ -436,7 +436,7 @@ class SecurityGroupDbMixin(ext_sg.SecurityGroupPluginBase):
                 raise ext_sg.SecurityGroupMissingIcmpType(
                     value=rule['port_range_max'])
 
-    def _validate_security_group_rules(self, context, security_group_rule):
+    def _validate_security_group_rules(self, context, security_group_rules):
         """Check that rules being installed.
 
         Check that all rules belong to the same security
@@ -445,8 +445,8 @@ class SecurityGroupDbMixin(ext_sg.SecurityGroupPluginBase):
         """
         new_rules = set()
         tenant_ids = set()
-        for rules in security_group_rule['security_group_rules']:
-            rule = rules.get('security_group_rule')
+        for rule_dict in security_group_rules['security_group_rules']:
+            rule = rule_dict.get('security_group_rule')
             new_rules.add(rule['security_group_id'])
 
             self._validate_port_range(rule)