Enable Process Monitor by default.

Process monitor is enabled by default by this patch,
with a default 60 second monitoring interval, this
interval was calculated early in the development
process to scale to 1000s of processes with light load.
We believe it's important to have it enabled to get
user feedback as we release kilo.

Process monitor is sucessfully enabled and backported
to Red Hat D/S distributions from icehouse to juno
without any issue.

Specific process monitor functional tests provide
coverage, also keepalived checks that it can be
properly respawned.

We should follow up with dhcp and l3 agent functional
testing for killing and checking their processes
correctly respawned. Normal process start/stop is
already validated by other functional tests and tempest.

DocImpact

Change-Id: I85fe31bee30714148168a293eea29fa0a37f9701
Implements: blueprint agent-child-processes-status

diff --git a/etc/neutron.conf b/etc/neutron.conf
index c68af4e66d90fca332c2125d39c323db38884fb2..e25d8e253754e0f91f0afe4e694cbaad69ec635d 100644 (file)
--- a/etc/neutron.conf
+++ b/etc/neutron.conf
@@ -652,7 +652,7 @@ lock_path = $state_path/lock
 # use_helper_for_ns_read = True
 
 # The interval to check external processes for failure in seconds (0=disabled)
-# check_child_processes_interval = 0
+# check_child_processes_interval = 60
 
 # Action to take when an external process spawned by an agent dies
 # Values:

diff --git a/neutron/agent/common/config.py b/neutron/agent/common/config.py
index 3f533fa3a34acb5a0a4a6cf1f4a39c2dfdae1201..429f2c4790433d442269675cf7dd01291f02572f 100644 (file)
--- a/neutron/agent/common/config.py
+++ b/neutron/agent/common/config.py
@@ -67,7 +67,7 @@ PROCESS_MONITOR_OPTS = [
     cfg.StrOpt('check_child_processes_action', default='respawn',
                choices=['respawn', 'exit'],
                help=_('Action to be executed when a child process dies')),
-    cfg.IntOpt('check_child_processes_interval', default=0,
+    cfg.IntOpt('check_child_processes_interval', default=60,
                help=_('Interval between checks of child process liveness '
                       '(seconds), use 0 to disable')),
 ]