]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix comments in api.rpc.handlers
authorAkihiro Motoki <motoki@da.jp.nec.com>
Sat, 30 Aug 2014 16:47:24 +0000 (01:47 +0900)
committerAkihiro Motoki <motoki@da.jp.nec.com>
Wed, 10 Sep 2014 06:13:49 +0000 (06:13 +0000)
Follow-up patch of RPC refactoring of bug 1359416.
It addresses minor comments in the above patch series.

Change-Id: I2d6268db777f0f73fda61a5a7d0967a91bcb292b
Closes-Bug: #1359416

neutron/api/rpc/handlers/securitygroups_rpc.py
neutron/plugins/ml2/rpc.py

index 857e99d8c496966972a308570d045d1999e07186..2a748cfbcc7961a575fdee40bc8de6e3257f2859 100644 (file)
@@ -17,14 +17,11 @@ from neutron import manager
 
 
 # TODO(amotoki): Move security group RPC API and agent callback
-# from securitygroups_rpc.py.
+# from neutron/agent/securitygroups_rpc.py.
 
 
 class SecurityGroupServerRpcCallback(n_rpc.RpcCallback):
-    """Callback for SecurityGroup agent RPC in plugin implementations.
-
-    Subclass which inherits this class must implement get_port_from_device().
-    """
+    """Callback for SecurityGroup agent RPC in plugin implementations."""
 
     # API version history:
     #   1.1 - Initial version
index 52d3980d92cb023375d0205d35da091f41ba4a7d..d9cb07efd46c7fbfe7d2bcf37cff041ac8df955f 100644 (file)
@@ -40,7 +40,9 @@ class RpcCallbacks(n_rpc.RpcCallback,
     #   1.0 Initial version (from openvswitch/linuxbridge)
     #   1.1 Support Security Group RPC
     #   1.2 Support get_devices_details_list
-    #   1.3 Support Distributed Virtual Router (DVR)
+    #   1.3 get_device_details rpc signature upgrade to obtain 'host' and
+    #       return value to include fixed_ips and device_owner for
+    #       the device port
 
     def __init__(self, notifier, type_manager):
         self.setup_tunnel_callback_mixin(notifier, type_manager)