]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
remove policy check for host_routes in update_port
authorjustin ljj <iamljj@gmail.com>
Thu, 30 Aug 2012 05:12:15 +0000 (13:12 +0800)
committerjustin ljj <iamljj@gmail.com>
Thu, 30 Aug 2012 05:41:30 +0000 (13:41 +0800)
Fixes bug 1043630

Port has no 'host_routes' attribute according to the latest V2 API
specification. So, policy check for 'host_routes' is not need any
more, just remove it in this patch.

Change-Id: I925e83d9825f89265843c15e71ee5ed4c33bad5f

etc/policy.json
quantum/api/v2/attributes.py
quantum/tests/unit/test_api_v2.py

index f53080cc541f55a1886cab6d051313d0f7485232..52feddf922e62a29effb741a7e97976e6521f413 100644 (file)
 
     "create_port": [],
     "create_port:mac_address": [["rule:admin_or_network_owner"]],
-    "create_port:host_routes": [["rule:admin_or_network_owner"]],
     "create_port:fixed_ips": [["rule:admin_or_network_owner"]],
     "get_port": [["rule:admin_or_owner"]],
     "update_port": [["rule:admin_or_owner"]],
-    "update_port:host_routes": [["rule:admin_or_network_owner"]],
     "update_port:fixed_ips": [["rule:admin_or_network_owner"]],
     "delete_port": [["rule:admin_or_owner"]]
 }
index 46a9bc84154b5963d504f4e71148bc38c912f953..0aee016097450ebf2a00db1e0389f3e681910cae 100644 (file)
@@ -220,10 +220,6 @@ RESOURCE_ATTRIBUTE_MAP = {
                       'default': ATTR_NOT_SPECIFIED,
                       'enforce_policy': True,
                       'is_visible': True},
-        'host_routes': {'allow_post': True, 'allow_put': True,
-                        'default': ATTR_NOT_SPECIFIED,
-                        'enforce_policy': True,
-                        'is_visible': False},
         'device_id': {'allow_post': True, 'allow_put': True,
                       'default': '',
                       'is_visible': True},
index 621a257fabbbebfc517dd798f76e7fb21f6c4694..6e271385b59d652d1b3da42bd5636994537542e9 100644 (file)
@@ -494,13 +494,11 @@ class JSONV2TestCase(APIv2TestBase):
         full_input = {'port': {'admin_state_up': True,
                                'mac_address': attributes.ATTR_NOT_SPECIFIED,
                                'fixed_ips': attributes.ATTR_NOT_SPECIFIED,
-                               'device_owner': '',
-                               'host_routes': attributes.ATTR_NOT_SPECIFIED}}
+                               'device_owner': ''}}
         full_input['port'].update(initial_input['port'])
         return_value = {'id': _uuid(), 'status': 'ACTIVE',
                         'admin_state_up': True,
                         'mac_address': 'ca:fe:de:ad:be:ef',
-                        'host_routes': [],
                         'device_id': device_id,
                         'device_owner': ''}
         return_value.update(initial_input['port'])