]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Add control_exchange and rpc_response_timeout options
authorZhongShengping <chdzsp@163.com>
Sat, 28 Jan 2017 04:59:08 +0000 (12:59 +0800)
committerZhongShengping <chdzsp@163.com>
Sat, 28 Jan 2017 04:59:08 +0000 (12:59 +0800)
Add control_exchange to configure an exchange name for message.
Add rpc_response_timeout to configure seconds time for waiting
for a response from a call.

Change-Id: I0d54accfea048fa394dac18e141a620d127579cf

manifests/init.pp
releasenotes/notes/add_messaging_default_parameters-813a34e99f22d134.yaml [new file with mode: 0644]
spec/classes/ceilometer_init_spec.rb

index ea1fb696624d919c27fd77ff95e29a9746100f68..3c3b2f420fb1ba7d9701620eebb2fc5f10b5437f 100644 (file)
 #      transport://user:pass@host1:port[,hostN:portN]/virtual_host
 #    Defaults to $::os_service_default
 #
+# [*rpc_response_timeout*]
+#  (Optional) Seconds to wait for a response from a call.
+#  Defaults to $::os_service_default
+#
+# [*control_exchange*]
+#   (Optional) The default exchange under which topics are scoped. May be
+#   overridden by an exchange name specified in the transport_url
+#   option.
+#   Defaults to $::os_service_default
+#
 # [*notification_transport_url*]
 #   (optional) A URL representing the messaging driver to use for notifications
 #   and its full configuration. Transport URLs take the form:
@@ -243,6 +253,8 @@ class ceilometer(
   $use_stderr                         = undef,
   $log_facility                       = undef,
   $default_transport_url              = $::os_service_default,
+  $rpc_response_timeout               = $::os_service_default,
+  $control_exchange                   = $::os_service_default,
   $notification_transport_url         = $::os_service_default,
   $rpc_backend                        = $::os_service_default,
   $rabbit_ha_queues                   = $::os_service_default,
@@ -398,7 +410,9 @@ deprecated. Please use ceilometer::default_transport_url instead.")
   }
 
   oslo::messaging::default { 'ceilometer_config':
-    transport_url => $default_transport_url,
+    transport_url        => $default_transport_url,
+    rpc_response_timeout => $rpc_response_timeout,
+    control_exchange     => $control_exchange,
   }
 
   oslo::cache { 'ceilometer_config':
diff --git a/releasenotes/notes/add_messaging_default_parameters-813a34e99f22d134.yaml b/releasenotes/notes/add_messaging_default_parameters-813a34e99f22d134.yaml
new file mode 100644 (file)
index 0000000..39d5e04
--- /dev/null
@@ -0,0 +1,7 @@
+---
+features:
+  - Add new parameter "control_exchange", the default exchange under
+    which topics are scoped. May be overridden by an exchange name
+    specified in the transport_url option.
+  - Add new parameter "rpc_response_timeout", seconds to wait for a
+    response from a call
index caf70ea1039c6191dc395018908689aa5f8b2d5d..2f28d6fea5f836b03b3ff3242b4c8f3f1b2c8e14 100644 (file)
@@ -124,6 +124,8 @@ describe 'ceilometer' do
 
     it 'configures default transport_url' do
       is_expected.to contain_ceilometer_config('DEFAULT/transport_url').with_value('<SERVICE DEFAULT>')
+      is_expected.to contain_ceilometer_config('DEFAULT/rpc_response_timeout').with_value('<SERVICE DEFAULT>')
+      is_expected.to contain_ceilometer_config('DEFAULT/control_exchange').with_value('<SERVICE DEFAULT>')
     end
 
     it 'configures notifications' do
@@ -137,10 +139,18 @@ describe 'ceilometer' do
     end
 
     context 'with overriden transport_url parameter' do
-      before { params.merge!( :default_transport_url => 'rabbit://rabbit_user:password@localhost:5673' ) }
+      before {
+        params.merge!(
+          :default_transport_url => 'rabbit://rabbit_user:password@localhost:5673',
+          :rpc_response_timeout  => '120',
+          :control_exchange      => 'ceilometer',
+        )
+      }
 
       it 'configures transport_url' do
         is_expected.to contain_ceilometer_config('DEFAULT/transport_url').with_value('rabbit://rabbit_user:password@localhost:5673')
+        is_expected.to contain_ceilometer_config('DEFAULT/rpc_response_timeout').with_value('120')
+        is_expected.to contain_ceilometer_config('DEFAULT/control_exchange').with_value('ceilometer')
       end
     end