]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Revert "Outputs the message about failing to bind
authorDan Prince <dprince@redhat.com>
Tue, 23 Dec 2014 16:56:17 +0000 (11:56 -0500)
committerDan Prince <dprince@redhat.com>
Tue, 23 Dec 2014 16:59:06 +0000 (11:59 -0500)
This reverts commit 8b59396182ceacb704e00afe1aee040a19e2a187.

This commit broke the ability to create Iscsi targets w/
cinder-rtstool. Everything seems to be working fine except there
are issues with regards to how rtstool output is parsed in that
any output (regardless of exit status) causes the command
to be marked as failed.

Suggesting this as a quick revert until we can investigate
the proper fix for error handling with cinder-rtstool.

Change-Id: I439433571ed1d01d162f685f8441b28bd6bffa43
Closes-bug: #1405228

cinder/cmd/rtstool.py

index a0f190f2428a799c9450932fabd9fda51049e6cd..76c4d11b376368440e80bbd38e9c23501f91e633 100644 (file)
@@ -78,7 +78,7 @@ def create(backing_device, name, userid, password, initiator_iqns=None):
         rtslib.NetworkPortal(tpg_new, '::0', 3260, mode='any')
     except rtslib.utils.RTSLibError:
         # TODO(emh): Binding to IPv6 fails sometimes -- let pass for now.
-        print(_('Failed to bind to IPv6.'))
+        pass
 
 
 def _lookup_target(target_iqn, initiator_iqn):