]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Code Review / openstack-build / cinder-build.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: d7d2599)
Specify lld in tgt config backends
authorDirk Mueller <dirk@dmllr.de>
Thu, 17 Apr 2014 11:49:05 +0000 (13:49 +0200)
committerDirk Mueller <dirk@dmllr.de>
Wed, 23 Apr 2014 12:45:14 +0000 (14:45 +0200)
Otherwise when running tgt-admin --delete, it might forget
to invoke tgtadmn with "--lld iscsi" in order to delete the low-level
iscsi exports, which can cause crashes or hangs later on.

Closes-Bug: #1311640
Change-Id: I436c67c30565089236e987d84ac2609eedd2d2c7

cinder/brick/iscsi/iscsi.py patch | blob | history

diff --git a/cinder/brick/iscsi/iscsi.py b/cinder/brick/iscsi/iscsi.py
index b28c83f22348d70660950fd3d4ecc91659bc0fae..a8f590313206509bb757541297d9dd8738babb85 100644 (file)
--- a/cinder/brick/iscsi/iscsi.py
+++ b/cinder/brick/iscsi/iscsi.py
@@ -82,11 +82,13 @@ class TgtAdm(TargetAdmin):
     VOLUME_CONF = """
                 <target %s>
                     backing-store %s
+                    lld iscsi
                 </target>
                   """
     VOLUME_CONF_WITH_CHAP_AUTH = """
                                 <target %s>
                                     backing-store %s
+                                    lld iscsi
                                     %s
                                 </target>
                                  """