]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Do not enforce glance_control_exchange
authorMathieu Gagné <mgagne@iweb.com>
Tue, 28 Jan 2014 23:18:00 +0000 (18:18 -0500)
committerMathieu Gagné <mgagne@iweb.com>
Tue, 28 Jan 2014 23:18:00 +0000 (18:18 -0500)
The default glance_control_exchange in Ceilometer has been changed
from 'glance_notifications' to 'glance' in grizzly-2. Glance always
had 'glance' for its control_exchange.

This was a bug in Ceilometer and puppet-ceilometer patched it.
It shouldn't anymore.

Change-Id: I217515c91f092fb3e8039dde2d14a7ab4cbb7245
Closes-bug: #1273878

manifests/init.pp
spec/classes/ceilometer_init_spec.rb

index 2493386085c6555a7e42dcb9ebec87ec7b4e35a5..3b46496fa8d90a490bef3abf632e5ce93ac02fe8 100644 (file)
@@ -182,9 +182,6 @@ class ceilometer(
     'DEFAULT/debug'                  : value => $debug;
     'DEFAULT/log_dir'                : value => $log_dir;
     'DEFAULT/verbose'                : value => $verbose;
-    # Fix a bad default value in ceilometer.
-    # Fixed in https://review.openstack.org/#/c/18487/
-    'DEFAULT/glance_control_exchange': value => 'glance';
     'DEFAULT/notification_topics'    : value => 'notifications';
   }
 
index b3d1113114bf9a46578eb53ba8d2ee7783568765..0e84aaa7451f96b0387a958a75b66a933e26f475 100644 (file)
@@ -144,10 +144,6 @@ describe 'ceilometer' do
       it { should contain_ceilometer_config('DEFAULT/syslog_log_facility').with_value('LOG_LOCAL0') }
     end
 
-    it 'fixes a bad value in ceilometer (glance_control_exchange)' do
-      should contain_ceilometer_config('DEFAULT/glance_control_exchange').with_value('glance')
-    end
-
     it 'configures notification_topics' do
       should contain_ceilometer_config('DEFAULT/notification_topics').with_value('notifications')
     end