]> review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/commitdiff
Lint cleanup
authorMorgan Haskel <morgan@puppetlabs.com>
Mon, 6 Apr 2015 18:29:02 +0000 (11:29 -0700)
committerMorgan Haskel <morgan@puppetlabs.com>
Mon, 6 Apr 2015 18:47:23 +0000 (11:47 -0700)
examples/force.pp
examples/key.pp
examples/source.pp

index 355d91f03a2e7a96cf7899b2140a24b967e4c103..c096b97d8a961d3574b9782767e62989776a90d2 100644 (file)
@@ -1,10 +1,10 @@
 #if you need to specify a release
-$rel_string = "-t ${release}"
+$rel_string = '-t <release>'
 #else
 $rel_string = ''
 
 #if you need to specify a version
-$ensure = $version
+$ensure = '<version>'
 #else 
 $ensure = installed
 
@@ -24,5 +24,5 @@ $config_missing = ''
 
 package { $package:
   ensure          => $ensure,
-  install_options => "${config_files} ${config_missing} ${release_string}",
+  install_options => "${config_files} ${config_missing} ${rel_string}",
 }
index 79e0e1b749ab17bb853548ba8188fa665d8529ab..cc8681fbf8aadfb315c143b2065e4d4ee19b8f43 100644 (file)
@@ -1,6 +1,6 @@
 # Declare Apt key for apt.puppetlabs.com source
 apt::key { 'puppetlabs':
-  key         => '4BD6EC30',
-  key_server  => 'pgp.mit.edu',
-  key_options => 'http-proxy="http://proxyuser:proxypass@example.org:3128"',
+  id      => '47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30',
+  server  => 'pgp.mit.edu',
+  options => 'http-proxy="http://proxyuser:proxypass@example.org:3128"',
 }
index 823b37b73632667f88d165e9559890cdb5decfcd..33dc2a1938601cdc8bde6492be77f1e38baa66fe 100644 (file)
@@ -4,26 +4,32 @@ class { 'apt': }
 # Install the puppetlabs apt source
 # Release is automatically obtained from lsbdistcodename fact if available.
 apt::source { 'puppetlabs':
-  location   => 'http://apt.puppetlabs.com',
-  repos      => 'main',
-  key        => '4BD6EC30',
-  key_server => 'pgp.mit.edu',
+  location => 'http://apt.puppetlabs.com',
+  repos    => 'main',
+  key      => {
+    id     => '47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30',
+    server => 'pgp.mit.edu',
+  },
 }
 
 # test two sources with the same key
 apt::source { 'debian_testing':
-  location   => 'http://debian.mirror.iweb.ca/debian/',
-  release    => 'testing',
-  repos      => 'main contrib non-free',
-  key        => 'A1BD8E9D78F7FE5C3E65D8AF8B48AD6246925553',
-  key_server => 'subkeys.pgp.net',
-  pin        => '-10',
+  location => 'http://debian.mirror.iweb.ca/debian/',
+  release  => 'testing',
+  repos    => 'main contrib non-free',
+  key      => {
+    id     => 'A1BD8E9D78F7FE5C3E65D8AF8B48AD6246925553',
+    server => 'subkeys.pgp.net',
+  },
+  pin      => '-10',
 }
 apt::source { 'debian_unstable':
-  location   => 'http://debian.mirror.iweb.ca/debian/',
-  release    => 'unstable',
-  repos      => 'main contrib non-free',
-  key        => 'A1BD8E9D78F7FE5C3E65D8AF8B48AD6246925553',
-  key_server => 'subkeys.pgp.net',
-  pin        => '-10',
+  location => 'http://debian.mirror.iweb.ca/debian/',
+  release  => 'unstable',
+  repos    => 'main contrib non-free',
+  key      => {
+    id     => 'A1BD8E9D78F7FE5C3E65D8AF8B48AD6246925553',
+    server => 'subkeys.pgp.net',
+  },
+  pin      => '-10',
 }