]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Correct arguments to logging function
authorAngus Lees <gus@inodes.org>
Wed, 17 Dec 2014 04:07:28 +0000 (15:07 +1100)
committerAngus Lees <gus@inodes.org>
Wed, 17 Dec 2014 04:07:28 +0000 (15:07 +1100)
ofctl_arg_supported contains a bad call to LOG.debug in an exception
path.

    LOG.debug("...%s. Exception: %s", (full_args, e))

This throws "TypeError: not enough arguments for format string" and
should be:

    LOG.debug("...%s. Exception: %s", full_args, e)

(Found via pylint)

Change-Id: Ib14666f60b16584f225b1e0c4fed82ef7e941aac
Closes-Bug: #1403296

neutron/cmd/sanity/checks.py

index d13b0f91d253406fc6762686f22af483ffd4e0f2..c672546a1bfcf54af1a8e2f073a1796dab83091a 100644 (file)
@@ -68,7 +68,7 @@ def ofctl_arg_supported(root_helper, cmd, **kwargs):
             agent_utils.execute(full_args, root_helper=root_helper)
         except RuntimeError as e:
             LOG.debug("Exception while checking supported feature via "
-                      "command %s. Exception: %s", (full_args, e))
+                      "command %s. Exception: %s", full_args, e)
             return False
         except Exception:
             LOG.exception(_LE("Unexpected exception while checking supported"