]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Put result in quotes
authorJoshua Harlow <harlowja@yahoo-inc.com>
Fri, 15 Aug 2014 00:02:32 +0000 (17:02 -0700)
committerJoshua Harlow <harlowja@yahoo-inc.com>
Fri, 15 Aug 2014 00:02:32 +0000 (17:02 -0700)
When a result is the empty string is is hard/confusing
to look at the logs and determine what the task result
was, to avoid this put the result in quotes so that it
is clear in the log message what is the result and what
is not.

Change-Id: I6f9c30e30999dcd8d7f0df26f8066d9f392fe1b9

cinder/flow_utils.py

index c5816c883e6e6f4e4819476190b2d021c56d1d89..d10ef4894dd69032c2e4702c369270ec1111fb8d 100644 (file)
@@ -107,7 +107,7 @@ class DynamicLogListener(base_listener.ListenerBase):
                     self._logger.log(level,
                                      _("Task '%(task_name)s' (%(task_uuid)s)"
                                        " transitioned into state '%(state)s'"
-                                       " with result %(result)s") %
+                                       " with result '%(result)s'") %
                                      {'task_name': details['task_name'],
                                       'task_uuid': details['task_uuid'],
                                       'state': state, 'result': result})