]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
SolidFire API RequestID is useless.
authorJohn Griffith <john.griffith@solidfire.com>
Tue, 9 Jul 2013 01:22:34 +0000 (19:22 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Tue, 9 Jul 2013 01:22:34 +0000 (19:22 -0600)
The SolidFire API can take an int or a string for a request-id,
when using an int however it needs to actually be a valid int.

The driver currently was doing an int(uuid) which is too large and
as a result get's truncated making it difficult or impossible to track
request-ids.

This patch chanes the generate request-id to form a hash of the uuid so
that it can be tracked.

Fixed bug: 1199198

Change-Id: I38d5e3d189e679678898c329a9fa173a47853d47

cinder/volume/drivers/solidfire.py

index ce4d56af6ee91029b69942b99f522451bebafd0e..1018bfb52adfe3b804e8b96211c318dccaae78a6 100644 (file)
@@ -117,7 +117,7 @@ class SolidFire(SanISCSIDriver):
         # can't be re-used
         retry_count = 5
         while retry_count > 0:
-            request_id = int(uuid.uuid4())  # just generate a random number
+            request_id = hash(uuid.uuid4())  # just generate a random number
             command = {'method': method_name,
                        'id': request_id}