Python 3: fix neutron.tests.unit.agent.dhcp.test_agent

A simple "list vs dict_keys" issue was preventing two tests from succeeding.

Change-Id: I9386ddc600005ebb1b3f5382f6e43c19d31d4213
Blueprint: neutron-python3

diff --git a/neutron/tests/unit/agent/dhcp/test_agent.py b/neutron/tests/unit/agent/dhcp/test_agent.py
index 96ddd988e1be36bad0455a93b7e3c3249b3c87bf..a64e98387afab70a8d116b4dcf317fed3ef11934 100644 (file)
--- a/neutron/tests/unit/agent/dhcp/test_agent.py
+++ b/neutron/tests/unit/agent/dhcp/test_agent.py
@@ -400,13 +400,14 @@ class TestDhcpAgent(base.BaseTestCase):
     def test_periodic_resync_helper(self):
         with mock.patch.object(dhcp_agent.eventlet, 'sleep') as sleep:
             dhcp = dhcp_agent.DhcpAgent(HOSTNAME)
-            dhcp.needs_resync_reasons = collections.OrderedDict(
+            resync_reasons = collections.OrderedDict(
                 (('a', 'reason1'), ('b', 'reason2')))
+            dhcp.needs_resync_reasons = resync_reasons
             with mock.patch.object(dhcp, 'sync_state') as sync_state:
                 sync_state.side_effect = RuntimeError
                 with testtools.ExpectedException(RuntimeError):
                     dhcp._periodic_resync_helper()
-                sync_state.assert_called_once_with(['a', 'b'])
+                sync_state.assert_called_once_with(resync_reasons.keys())
                 sleep.assert_called_once_with(dhcp.conf.resync_interval)
                 self.assertEqual(len(dhcp.needs_resync_reasons), 0)
 
@@ -1062,7 +1063,7 @@ class TestNetworkCache(base.BaseTestCase):
         nc = dhcp_agent.NetworkCache()
         nc.put(fake_network)
 
-        self.assertEqual(nc.get_network_ids(), [fake_network.id])
+        self.assertEqual(list(nc.get_network_ids()), [fake_network.id])
 
     def test_get_network_by_subnet_id(self):
         nc = dhcp_agent.NetworkCache()

diff --git a/tox.ini b/tox.ini
index b53a74799ea895c1051dbed342d98cb3fb136077..ab0279071ac8172351f11a75810203fc8e14dae5 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -205,6 +205,7 @@ commands = python -m testtools.run \
     neutron.tests.unit.agent.linux.test_bridge_lib \
     neutron.tests.unit.agent.linux.test_ip_link_support \
     neutron.tests.unit.agent.linux.test_interface \
+    neutron.tests.unit.agent.dhcp.test_agent \
     neutron.tests.unit.test_manager \
     neutron.tests.unit.test_service \
     neutron.tests.unit.test_auth \