]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
Fix comment in uid and gid insync
authorFélix-Antoine Fortin <felix-antoine.fortin@calculquebec.ca>
Fri, 1 Oct 2021 18:17:45 +0000 (14:17 -0400)
committerFélix-Antoine Fortin <felix-antoine.fortin@calculquebec.ca>
Fri, 1 Oct 2021 18:17:45 +0000 (14:17 -0400)
lib/puppet/type/firewall.rb

index 75724f75fe7440a00f559874225fe1e2e2c6bf7b..e4cb1a2fafa39246adc3c83718f4235873393e3a 100644 (file)
@@ -1390,14 +1390,14 @@ Puppet::Type.newtype(:firewall) do
         should_negate = '!'
       end
 
-      # If 'should' contains anything other than digits,
+      # If 'should' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
       # to UID
       unless should[%r{[0-9]+(-[0-9]+)?}] == should
         should = Etc.getpwnam(should).uid
       end
 
-      # If 'is' contains anything other than digits,
+      # If 'is' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
       # to UID
       unless is[%r{[0-9]+(-[0-9]+)?}] == is
@@ -1439,16 +1439,16 @@ Puppet::Type.newtype(:firewall) do
         should_negate = '!'
       end
 
-      # If 'should' contains anything other than digits,
+      # If 'should' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
-      # to UID
+      # to GID
       unless should[%r{[0-9]+(-[0-9]+)?}] == should
         should = Etc.getgrnam(should).gid
       end
 
-      # If 'is' contains anything other than digits,
+      # If 'is' contains anything other than digits or digit range,
       # we assume that we have to do a lookup to convert
-      # to UID
+      # to GID
       unless is[%r{[0-9]+(-[0-9]+)?}] == is
         is = Etc.getgrnam(is).gid
       end