]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Activate pep8 check that _ is imported
authorJames Carey <jecarey@us.ibm.com>
Thu, 30 Oct 2014 15:28:48 +0000 (15:28 +0000)
committerJames Carey <jecarey@us.ibm.com>
Thu, 30 Oct 2014 21:28:41 +0000 (21:28 +0000)
Removed the specification in tox.ini that _ is a builtin so that
it will no longer assume that _ does not need to be imported.

The correct import is:

    from cinder.i18n import _

Activating this check did not flag any violations in cinder.

Change-Id: Ifc789514d2462c059eb9f003fac288e751331ded

tox.ini

diff --git a/tox.ini b/tox.ini
index 3f08900432db2dd204a8bb5918c45d06a580df16..b147982edf5dbde0bd17c68391b45cbfdc55c1cf 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -73,7 +73,6 @@ commands = {posargs}
 
 
 ignore = E251,E265,H302,H402,H405,H803,H904
-builtins = _
 exclude = .git,.venv,.tox,dist,tools,doc,common,*egg,build
 max-complexity=30