]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Pass the mirrorlog option as two arguments.
authorVishvananda Ishaya <vishvananda@gmail.com>
Wed, 26 Mar 2014 19:09:28 +0000 (12:09 -0700)
committerVishvananda Ishaya <vishvananda@gmail.com>
Wed, 26 Mar 2014 20:24:57 +0000 (13:24 -0700)
We don't use shell=True when we Popen, so we have to keep all
arguments as separate values.

Change-Id: Ic35fad36be72386d3496920e259c32fe16625046
Closes-bug: 1298017

cinder/brick/local_dev/lvm.py

index 37dc1742f8c2b004306d59fcf009730e54d70af7..0cca76af0f4b51b99c81d46eb6f4a88340fd661e 100644 (file)
@@ -461,7 +461,7 @@ class LVM(executor.Executor):
 
         if mirror_count > 0:
             cmd.extend(['-m', mirror_count, '--nosync',
-                        '--mirrorlog mirrored'])
+                        '--mirrorlog', 'mirrored'])
             terras = int(size_str[:-1]) / 1024.0
             if terras >= 1.5:
                 rsize = int(2 ** math.ceil(math.log(terras) / math.log(2)))