heat engine : error on resource update with invalid properties

If properties validation fails, raise an error so the resource is
marked as UPDATE_FAILED, we don't want to go ahead and try running
handle_update anyway

Change-Id: I5f748b9de6a2b02d26421a5b6e0b1b5f0db25d0c
Signed-off-by: Steven Hardy <shardy@redhat.com>

diff --git a/heat/engine/resource.py b/heat/engine/resource.py
index aee065f43643a02b4193d115ed20e04eb6be76dc..52f1c34aa7a9af9a3434588ee235d03323501381 100644 (file)
--- a/heat/engine/resource.py
+++ b/heat/engine/resource.py
@@ -255,7 +255,7 @@ class Resource(object):
             self.t = self.stack.resolve_static_data(json_snippet)
             err = self.properties.validate()
             if err:
-                return err
+                raise ValueError(err)
             if callable(getattr(self, 'handle_update', None)):
                 result = self.handle_update()
         except Exception as ex: