Maybe I'm just too picky but I usually call this stuff out in reviews
even if I decide to +2 the patch set.
Change-Id: I5a2667d44203147e112f5a1d7573105478d805f7
* Do not make multiple changes in one patch unless absolutely necessary.
Cleaning up nearby functions or fixing a small bug you noticed while working
on something else makes the patch very difficult to review. It also makes
- cherry-picking and reverting very difficult.
+ cherry-picking and reverting very difficult. Even apparently minor changes
+ such as reformatting whitespace around your change can burden reviewers and
+ cause merge conflicts.
* If a fix or feature requires code refactoring, submit the refactoring as a
separate patch than the one that changes the logic. Otherwise
it's difficult for a reviewer to tell the difference between mistakes