]> review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/commitdiff
autorequire dirmngr package
authorTomas Barton <barton.tomas@gmail.com>
Wed, 13 Sep 2017 09:16:36 +0000 (11:16 +0200)
committerTomas Barton <barton.tomas@gmail.com>
Wed, 13 Sep 2017 09:16:36 +0000 (11:16 +0200)
* add Debian 9 as supported system
* move dirmngr ensure to init.pp

manifests/init.pp
manifests/key.pp
manifests/setting.pp
metadata.json

index c89c2230cfd684c108acb924ca74868f345e8222..44e66ce51ff2dd00980603ae05423c11d092cae3 100644 (file)
@@ -178,4 +178,19 @@ class apt (
   if $pins {
     create_resources('apt::pin', $pins)
   }
+
+  # required for adding GPG keys on Debian 9 (and derivatives)
+  case $facts['os']['name'] {
+    'Debian': {
+      if versioncmp($facts['os']['release']['full'], '9.0') >= 0 {
+        ensure_packages(['dirmngr'])
+      }
+    }
+    'Ubuntu': {
+      if versioncmp($facts['os']['release']['full'], '17.04') >= 0 {
+        ensure_packages(['dirmngr'])
+      }
+    }
+    default: { }
+  }
 }
index dfa1daf2b61935886b79cf22b5876511807397c4..31fc4859b594e108180ab226e2b4182673444df2 100644 (file)
@@ -33,6 +33,24 @@ define apt::key (
           server  => $server,
           options => $options,
         } -> anchor { "apt_key ${id} present": }
+
+        case $facts['os']['name'] {
+          'Debian': {
+            if versioncmp($facts['os']['release']['full'], '9.0') >= 0 {
+              AptKey<| title == $title |> {
+                require => Package['dirmngr']
+              }
+            }
+          }
+          'Ubuntu': {
+            if versioncmp($facts['os']['release']['full'], '17.04') >= 0 {
+              AptKey<| title == $title |> {
+                require => Package['dirmngr']
+              }
+            }
+          }
+          default: { }
+        }
       }
     }
 
index 333f5534ad6c49a108a2eda7e570206a79833299..3809239f0d1b522ac1caa0cb2e72d828c347a406 100644 (file)
@@ -50,19 +50,4 @@ define apt::setting (
     notify  => $_notify,
   }
 
-  # required for adding apt GPG keys
-  case $facts['os']['name'] {
-    'Debian': {
-      if versioncmp($facts['os']['release']['full'], '9.0') >= 0 {
-        ensure_packages(['dirmngr'])
-      }
-    }
-    'Ubuntu': {
-      if versioncmp($facts['os']['release']['full'], '17.04') >= 0 {
-        ensure_packages(['dirmngr'])
-      }
-    }
-    default: { }
-  }
-
 }
index a307e5db9bbb4161c39291f52c092cbf6cf072fd..4e65705322cf6e65663e3224b75eecbc388f1052 100644 (file)
@@ -16,7 +16,8 @@
       "operatingsystem": "Debian",
       "operatingsystemrelease": [
         "7",
-        "8"
+        "8",
+        "9"
       ]
     },
     {