]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Remove default=None for configuration bindings
authorGary Kotton <gkotton@vmware.com>
Mon, 2 Nov 2015 08:41:29 +0000 (00:41 -0800)
committergaryk <gkotton@vmware.com>
Thu, 5 Nov 2015 10:29:02 +0000 (10:29 +0000)
The default value for a configuration variable is None. There is
no need to specifically set these as None.

The line where this is done is:
https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L684

TrivialFix

Change-Id: Iedf29b13d69ea9f2eb4d5aa746d7c1da8d83bafc

neutron/agent/metadata/config.py
neutron/agent/metadata/namespace_proxy.py
neutron/common/config.py
neutron/tests/tempest/config.py

index bfc21104168e3fb004949eebe8b426ee369a5c18..67e5e1eb8db31b7155966bf775000841da16667e 100644 (file)
@@ -36,7 +36,6 @@ SHARED_OPTS = [
 
 DRIVER_OPTS = [
     cfg.BoolOpt('metadata_proxy_watch_log',
-                default=None,
                 help=_("Enable/Disable log watch by metadata proxy. It "
                        "should be disabled when metadata_proxy_user/group "
                        "is not allowed to read/write its log file and "
index ed87871c0afb88de714d6fb1c361e3bd0cc59c49..1af885d2779c8b7d5eec56cd3b6a14e4f8c35e28 100644 (file)
@@ -158,11 +158,9 @@ def main():
                    help=_('Location of Metadata Proxy UNIX domain '
                           'socket')),
         cfg.StrOpt('metadata_proxy_user',
-                   default=None,
                    help=_("User (uid or name) running metadata proxy after "
                           "its initialization")),
         cfg.StrOpt('metadata_proxy_group',
-                   default=None,
                    help=_("Group (gid or name) running metadata proxy after "
                           "its initialization")),
         cfg.BoolOpt('metadata_proxy_watch_log',
index b346ba68dff49d472b8b5dc2ffd2e7892582c8ed..a598f73f427b34753d266adef27aeaa1f302ec6d 100644 (file)
@@ -72,10 +72,10 @@ core_opts = [
                help=_("Maximum number of fixed ips per port. This option "
                       "is deprecated and will be removed in the N "
                       "release.")),
-    cfg.StrOpt('default_ipv4_subnet_pool', default=None,
+    cfg.StrOpt('default_ipv4_subnet_pool',
                help=_("Default IPv4 subnet-pool to be used for automatic "
                       "subnet CIDR allocation")),
-    cfg.StrOpt('default_ipv6_subnet_pool', default=None,
+    cfg.StrOpt('default_ipv6_subnet_pool',
                help=_("Default IPv6 subnet-pool to be used for automatic "
                       "subnet CIDR allocation")),
     cfg.IntOpt('dhcp_lease_duration', default=86400,
@@ -113,7 +113,7 @@ core_opts = [
                 help=_('If True, effort is made to advertise MTU settings '
                        'to VMs via network methods (DHCP and RA MTU options) '
                        'when the network\'s preferred MTU is known.')),
-    cfg.StrOpt('ipam_driver', default=None,
+    cfg.StrOpt('ipam_driver',
                help=_('IPAM driver to use.')),
     cfg.BoolOpt('vlan_transparent', default=False,
                 help=_('If True, then allow plugins that support it to '
index 200b24736f087abec678db6340fe4bf2f40c12e8..256d687dd8de67ca50f4f5dd4e5ebd474befbac5 100644 (file)
@@ -73,7 +73,6 @@ IdentityGroup = [
                 default=False,
                 help="Set to True if using self-signed SSL certificates."),
     cfg.StrOpt('ca_certificates_file',
-               default=None,
                help='Specify a CA bundle file to use in verifying a '
                     'TLS (https) server certificate.'),
     cfg.StrOpt('uri',