]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Merge "Hacking Checks for assertTrue/IsNone()"
authorJenkins <jenkins@review.openstack.org>
Thu, 26 Nov 2015 15:54:58 +0000 (15:54 +0000)
committerGerrit Code Review <review@openstack.org>
Thu, 26 Nov 2015 15:54:58 +0000 (15:54 +0000)
1  2 
cinder/tests/unit/api/contrib/test_admin_actions.py
cinder/tests/unit/api/v1/test_volumes.py
cinder/tests/unit/api/v2/test_volumes.py
cinder/tests/unit/scheduler/test_host_manager.py
cinder/tests/unit/test_backup.py
cinder/tests/unit/test_gpfs.py
cinder/tests/unit/test_hpe3par.py
cinder/tests/unit/test_ibm_flashsystem.py
cinder/tests/unit/test_ibm_flashsystem_iscsi.py
cinder/tests/unit/test_storwize_svc.py
cinder/tests/unit/test_vmware_vmdk.py

Simple merge
Simple merge
index fe8b4215b646e19bd1837339aec6b2fb59d4c9cb,5ddd34783e92f852932ec677013177d45000f826..970beeecbbf42ac62c0483ceff545d0560b72de1
@@@ -1990,13 -1969,13 +1990,13 @@@ class HPE3PARBaseDriver(object)
              model_update = self.driver.create_volume_from_snapshot(
                  volume,
                  self.snapshot)
-             self.assertEqual(None, model_update)
+             self.assertIsNone(model_update)
  
 -            comment = (
 -                '{"snapshot_id": "2f823bdc-e36e-4dc8-bd15-de1c7a28ff31",'
 -                ' "display_name": "Foo Volume",'
 -                ' "volume_id": "d03338a9-9115-48a3-8dfc-35cdfcdc15a7"}')
 -
 +            comment = Comment({
 +                "snapshot_id": "2f823bdc-e36e-4dc8-bd15-de1c7a28ff31",
 +                "display_name": "Foo Volume",
 +                "volume_id": "d03338a9-9115-48a3-8dfc-35cdfcdc15a7",
 +            })
              volume_name_3par = common._encode_name(volume['id'])
              osv_matcher = 'osv-' + volume_name_3par
              omv_matcher = 'omv-' + volume_name_3par
              model_update = self.driver.create_volume_from_snapshot(
                  volume,
                  self.snapshot)
-             self.assertEqual(None, model_update)
+             self.assertIsNone(model_update)
  
 -            comment = (
 -                '{"snapshot_id": "2f823bdc-e36e-4dc8-bd15-de1c7a28ff31",'
 -                ' "display_name": "Foo Volume",'
 -                ' "volume_id": "d03338a9-9115-48a3-8dfc-35cdfcdc15a7"}')
 +            comment = Comment({
 +                "snapshot_id": "2f823bdc-e36e-4dc8-bd15-de1c7a28ff31",
 +                "display_name": "Foo Volume",
 +                "volume_id": "d03338a9-9115-48a3-8dfc-35cdfcdc15a7",
 +            })
  
              volume_name_3par = common._encode_name(volume['id'])
              osv_matcher = 'osv-' + volume_name_3par
Simple merge