]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Python 3: fix test_provider_configuration
authorCyril Roelandt <cyril@redhat.com>
Fri, 17 Jul 2015 17:27:36 +0000 (17:27 +0000)
committerCyril Roelandt <cyril@redhat.com>
Fri, 17 Jul 2015 17:39:18 +0000 (19:39 +0200)
We cannot compare a dict_keys/dict_values object with a list.

Change-Id: I6dbbe5eb4e98ccfc41109a5d93a22cda910774ee
Blueprint: neutron-python3

neutron/tests/unit/services/test_provider_configuration.py
tox.ini

index c5a5a3eb336182f61db681a0d68b4c617c5ab8ae..a10b6f783a9c190e82c2b34ed78e06bc2db38a13 100644 (file)
@@ -128,9 +128,9 @@ class ProviderConfigurationTestCase(base.BaseTestCase):
                 'default': False}
         pconf.add_provider(prov)
         self.assertEqual(len(pconf.providers), 1)
-        self.assertEqual(pconf.providers.keys(),
+        self.assertEqual(list(pconf.providers.keys()),
                          [(constants.LOADBALANCER, 'name')])
-        self.assertEqual(pconf.providers.values(),
+        self.assertEqual(list(pconf.providers.values()),
                          [{'driver': 'path', 'default': False}])
 
     def test_add_duplicate_provider(self):
diff --git a/tox.ini b/tox.ini
index e6abe77d0551656494498e461af1b85e417dcc26..518b6655f6ac0d7a01473bf31573487910920bc7 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -106,6 +106,7 @@ commands = python -m testtools.run \
     neutron.tests.unit.services.metering.drivers.test_iptables \
     neutron.tests.unit.services.metering.agents.test_metering_agent \
     neutron.tests.unit.services.l3_router.test_l3_apic \
+    neutron.tests.unit.services.test_provider_configuration \
     neutron.tests.unit.plugins.ml2.drivers.mech_sriov.agent.test_sriov_nic_agent \
     neutron.tests.unit.plugins.ml2.drivers.mech_sriov.agent.test_eswitch_manager \
     neutron.tests.unit.plugins.ml2.drivers.mech_sriov.agent.common.test_config \