]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix UT for L2pop test_get_agent_ports_no_data()
authorJakub Libosvar <libosvar@redhat.com>
Tue, 6 Jan 2015 22:21:57 +0000 (23:21 +0100)
committerJakub Libosvar <libosvar@redhat.com>
Wed, 7 Jan 2015 19:06:09 +0000 (20:06 +0100)
Previously loop in this test has never been executed because returned
generator was empty. This patch validates that generator is empty.

Change-Id: I900cd7bccee16487ab5469a2222afd294d9dee25
Closes-Bug: #1365388

neutron/tests/unit/agent/test_l2population_rpc.py

index b0b8f7e49019fda76987367a5318f67379180315..282d5c4fb190712812e4282e1ed6254d1142ae58 100644 (file)
@@ -26,10 +26,8 @@ class TestL2populationRpcCallBackTunnelMixin(
     l2population_rpc_base.TestL2populationRpcCallBackTunnelMixinBase):
 
     def test_get_agent_ports_no_data(self):
-        for lvm, agent_ports in self.fakeagent.get_agent_ports(
-            self.fdb_entries1, {}):
-            self.assertIsNone(lvm)
-            self.assertEqual({}, agent_ports)
+        self.assertFalse(
+            list(self.fakeagent.get_agent_ports(self.fdb_entries1, {})))
 
     def test_get_agent_ports_non_existence_key_in_lvm(self):
         results = {}