]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Avoid DuplicateOptError in functional tests
authorSergey Belous <sbelous@mirantis.com>
Tue, 13 Oct 2015 14:50:05 +0000 (17:50 +0300)
committerSergey Belous <sbelous@mirantis.com>
Tue, 13 Oct 2015 14:52:18 +0000 (17:52 +0300)
Some test require to register options with oslo.Config,
but now some of them use global cfg.CONF for it.
This can cause the DuplicateOptError if two tests tried to
register the same option with different values of config.
We should use the oslo_config fixture [1]
in functional tests to avoid it.

[1] http://git.openstack.org/cgit/openstack/oslo.config/tree/oslo_config/fixture.py

Closes-bug: #1505715
Change-Id: I5c2340c0af054dfa78788cbc61dfb1fd9feea535

neutron/tests/functional/agent/l3/test_keepalived_state_change.py

index 8c781129de78395c8a823f803e5c14485fb6e86a..107e59ee4abba20fd252eba49c2439c245545b95 100644 (file)
@@ -16,6 +16,7 @@ import os
 
 import mock
 from oslo_config import cfg
+from oslo_config import fixture as fixture_config
 from oslo_utils import uuidutils
 
 from neutron.agent.l3 import keepalived_state_change
@@ -25,7 +26,8 @@ from neutron.tests.functional import base
 class TestKeepalivedStateChange(base.BaseSudoTestCase):
     def setUp(self):
         super(TestKeepalivedStateChange, self).setUp()
-        cfg.CONF.register_opt(
+        self.conf_fixture = self.useFixture(fixture_config.Config())
+        self.conf_fixture.register_opt(
             cfg.StrOpt('metadata_proxy_socket',
                        default='$state_path/metadata_proxy',
                        help=_('Location of Metadata Proxy UNIX domain '