]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
use skipIf for all quantum test skip checks
authorSteve Baker <sbaker@redhat.com>
Wed, 15 May 2013 03:43:29 +0000 (15:43 +1200)
committerSteve Baker <sbaker@redhat.com>
Wed, 15 May 2013 22:49:39 +0000 (10:49 +1200)
Change-Id: I999c13fd5d2816374ee9fb4d2abe57557583ed9a

heat/tests/test_quantum.py

index f83ab6ddca1d18bfbc03809c4a2a45ac37b531ac..65ed7ba8d88aa787630892e0b083bbdafe91c494 100644 (file)
@@ -227,8 +227,8 @@ class QuantumTest(HeatTestCase):
                           'router:external': True,
                           'admin_state_up': False}, props)
 
+    @skipIf(net.clients.quantumclient is None, 'quantumclient unavailable')
     def test_net(self):
-        skipIf(net.clients.quantumclient is None, 'quantumclient unavailable')
 
         fq = FakeQuantum()
         net.Net.quantum().MultipleTimes().AndReturn(fq)
@@ -267,9 +267,8 @@ class QuantumFloatingIPTest(HeatTestCase):
         self.m.StubOutWithMock(port.Port, 'quantum')
         setup_dummy_db()
 
+    @skipIf(net.clients.quantumclient is None, 'quantumclient unavailable')
     def test_floating_ip(self):
-        if net.clients.quantumclient is None:
-            raise SkipTest
 
         fq = FakeQuantum()
         floatingip.FloatingIP.quantum().MultipleTimes().AndReturn(fq)
@@ -302,9 +301,8 @@ class QuantumFloatingIPTest(HeatTestCase):
 
         self.m.VerifyAll()
 
+    @skipIf(net.clients.quantumclient is None, 'quantumclient unavailable')
     def test_port(self):
-        if net.clients.quantumclient is None:
-            raise SkipTest
 
         fq = FakeQuantum()
         port.Port.quantum().MultipleTimes().AndReturn(fq)
@@ -337,9 +335,8 @@ class QuantumFloatingIPTest(HeatTestCase):
 
         self.m.VerifyAll()
 
+    @skipIf(net.clients.quantumclient is None, 'quantumclient unavailable')
     def test_floatip_port(self):
-        if net.clients.quantumclient is None:
-            raise SkipTest
 
         fq = FakeQuantum()
         floatingip.FloatingIP.quantum().MultipleTimes().AndReturn(fq)