]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix l3_agentschedulers_db for consistency of code
authorHirofumi Ichihara <ichihara.hirofumi@lab.ntt.co.jp>
Thu, 12 Mar 2015 09:26:57 +0000 (18:26 +0900)
committerHirofumi Ichihara <ichihara.hirofumi@lab.ntt.co.jp>
Thu, 12 Mar 2015 09:26:57 +0000 (18:26 +0900)
Fix for consistency between l3_agentschedulers_db and agentschedulers_db.

Change-Id: I62d411a3effec5eb3335306298959635768c0999

neutron/db/l3_agentschedulers_db.py

index c0142b22b98965d3948996806f2d342fcd666025..d658b5bcf537ba4bca6629de73269bbd079bd159 100644 (file)
@@ -260,8 +260,6 @@ class L3AgentSchedulerDbMixin(l3agentscheduler.L3AgentSchedulerPluginBase,
                 context, [router_id], new_agent.host)
 
     def list_routers_on_l3_agent(self, context, agent_id):
-        # Exception thrown if the requested agent does not exist.
-        self._get_agent(context, agent_id)
         query = context.session.query(RouterL3AgentBinding.router_id)
         query = query.filter(RouterL3AgentBinding.l3_agent_id == agent_id)
 
@@ -270,6 +268,8 @@ class L3AgentSchedulerDbMixin(l3agentscheduler.L3AgentSchedulerPluginBase,
             return {'routers':
                     self.get_routers(context, filters={'id': router_ids})}
         else:
+            # Exception will be thrown if the requested agent does not exist.
+            self._get_agent(context, agent_id)
             return {'routers': []}
 
     def _get_active_l3_agent_routers_sync_data(self, context, host, agent,