]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Small cleanups in BaseVD/VolumeDriver
authorEric Harney <eharney@redhat.com>
Thu, 20 Aug 2015 19:11:48 +0000 (15:11 -0400)
committerEric Harney <eharney@redhat.com>
Thu, 20 Aug 2015 19:24:50 +0000 (15:24 -0400)
self._throttle is defined outside of __init__.

VolumeDriver's initialize_connection signature doesn't
match the method it overrides from BaseVD.

Change-Id: Ie9f741ad331a79e3a85fd586f6393f8f80aa2932

cinder/volume/driver.py

index ba2fe05639061e8d2384b9dfd6bc6e01c24d9855..79cc69152e12f842c3d50daa2d5a82d57c9bae6d 100644 (file)
@@ -294,6 +294,7 @@ class BaseVD(object):
             utils.setup_tracing(self.configuration.safe_get('trace_flags'))
         self.set_execute(execute)
         self._stats = {}
+        self._throttle = None
 
         self.pools = []
 
@@ -1543,7 +1544,7 @@ class VolumeDriver(ConsistencyGroupVD, TransferVD, ManageableVD, ExtendVD,
     def remove_export_snapshot(self, context, snapshot):
         raise NotImplementedError()
 
-    def initialize_connection(self, volume, connector):
+    def initialize_connection(self, volume, connector, **kwargs):
         raise NotImplementedError()
 
     def initialize_connection_snapshot(self, snapshot, connector, **kwargs):