]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Add missing unit test for goodness weigher
authorVipin Balachandran <vbala@vmware.com>
Sun, 31 May 2015 07:11:36 +0000 (12:41 +0530)
committerVipin Balachandran <vbala@vmware.com>
Tue, 2 Jun 2015 13:29:02 +0000 (18:59 +0530)
Add a unit test for goodness weigher to test unset goodness
function in host capabilities.

Change-Id: I67f86d065f2c740a7beef641250b0881cf63deaa

cinder/tests/unit/scheduler/test_goodness_weigher.py

index c042d1f718b1debc9635cba8fdbe370f591e4df5..d0a19a4f1a5ba7acc8ab13ee71e70693275decd5 100644 (file)
@@ -24,6 +24,19 @@ class GoodnessWeigherTestCase(test.TestCase):
     def setUp(self):
         super(GoodnessWeigherTestCase, self).setUp()
 
+    def test_goodness_weigher_with_no_goodness_function(self):
+        weigher = goodness.GoodnessWeigher()
+        host_state = fakes.FakeHostState('host1', {
+            'host': 'host.example.com',
+            'capabilities': {
+                'foo': '50'
+            }
+        })
+
+        weight_properties = {}
+        weight = weigher._weigh_object(host_state, weight_properties)
+        self.assertEqual(0, weight)
+
     def test_goodness_weigher_passing_host(self):
         weigher = goodness.GoodnessWeigher()
         host_state = fakes.FakeHostState('host1', {