]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Drop ResellerAdmin role from ceilometer user
authorTakashi Kajinami <tkajinam@redhat.com>
Sun, 18 Apr 2021 14:22:05 +0000 (23:22 +0900)
committerTakashi Kajinami <tkajinam@redhat.com>
Sun, 18 Apr 2021 14:25:06 +0000 (23:25 +0900)
The ResellerAdmin role is no longer required because ceilometer doesn't
comminucate with Swift directly but only via Gnocchi.

Change-Id: I8111890a588b84f18ff34bc85794963b905cb844

manifests/keystone/auth.pp
releasenotes/notes/reseller-admin-45b1cad10ec19b99.yaml [new file with mode: 0644]
spec/classes/ceilometer_keystone_auth_spec.rb

index 7e1adb0fd3ffd9260b9bdf16d6b304afadaa310e..571256fb4f6ae43d7bd2467db7285aee6de888a7 100644 (file)
@@ -125,16 +125,5 @@ class ceilometer::keystone::auth (
     password            => $password,
     email               => $email,
     tenant              => $tenant,
-    roles               => ['admin', 'ResellerAdmin'],
   }
-
-  if $configure_user_role {
-    if !defined(Keystone_role['ResellerAdmin']) {
-      keystone_role { 'ResellerAdmin':
-        ensure => present,
-      }
-    }
-    Keystone_role['ResellerAdmin'] -> Keystone_user_role["${auth_name}@${tenant}"]
-  }
-
 }
diff --git a/releasenotes/notes/reseller-admin-45b1cad10ec19b99.yaml b/releasenotes/notes/reseller-admin-45b1cad10ec19b99.yaml
new file mode 100644 (file)
index 0000000..3e1c935
--- /dev/null
@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    The ``ResellerAdmin`` role is no longer assigned to the ceilometer user
+    in Keystone.
index 0063ebf04549643a3c6892fca09be71241ba13ca..ca8e63b365557dbf86aaf9248174f9bd32a2b9e1 100644 (file)
@@ -32,8 +32,7 @@ describe 'ceilometer::keystone::auth' do
 
       it 'configures ceilometer user roles' do
         is_expected.to contain_keystone_user_role("#{default_params[:auth_name]}@#{default_params[:tenant]}").with(
-          :ensure  => 'present',
-          :roles   => ['admin','ResellerAdmin']
+          :ensure => 'present',
         )
       end
     end
@@ -59,8 +58,7 @@ describe 'ceilometer::keystone::auth' do
 
       it 'configures ceilometer user roles' do
         is_expected.to contain_keystone_user_role("#{params[:auth_name]}@#{params[:tenant]}").with(
-          :ensure  => 'present',
-          :roles   => ['admin','ResellerAdmin']
+          :ensure => 'present',
         )
       end
     end