]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Assume that subclass validates value of UUID
authorGary Kotton <gkotton@redhat.com>
Thu, 19 Jul 2012 10:16:34 +0000 (06:16 -0400)
committerGary Kotton <gkotton@redhat.com>
Thu, 19 Jul 2012 16:37:35 +0000 (12:37 -0400)
Change-Id: I8501d10a798cc90c027bb981c5a3ca5a0ef6e622

quantum/db/db_base_plugin_v2.py

index 4f9832224941322d46fba5f2231dd097e53dfce2..0671e310aae635ef741e6bd62f4876abbddb62ba 100644 (file)
@@ -640,13 +640,6 @@ class QuantumDbPluginV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
 
     def create_network(self, context, network):
         n = network['network']
-        # Ensure id is valid from plugin
-        if n.get('id'):
-            res = attributes._validate_regex(n.get('id'),
-                                             attributes.UUID_PATTERN)
-            if res:
-                raise TypeError('Invalid input for id. Reason: %s.' % res)
-
         # NOTE(jkoelker) Get the tenant_id outside of the session to avoid
         #                unneeded db action if the operation raises
         tenant_id = self._get_tenant_id_for_create(context, n)
@@ -691,13 +684,6 @@ class QuantumDbPluginV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
 
     def create_subnet(self, context, subnet):
         s = subnet['subnet']
-        # Ensure id is valid from plugin
-        if s.get('id'):
-            res = attributes._validate_regex(n.get('id'),
-                                             attributes.UUID_PATTERN)
-            if res:
-                raise TypeError('Invalid input for id. Reason: %s.' % res)
-
         net = netaddr.IPNetwork(s['cidr'])
         if s['gateway_ip'] == attributes.ATTR_NOT_SPECIFIED:
             s['gateway_ip'] = str(netaddr.IPAddress(net.first + 1))
@@ -755,13 +741,6 @@ class QuantumDbPluginV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
 
     def create_port(self, context, port):
         p = port['port']
-        # Ensure id is valid from plugin
-        if p.get('id'):
-            res = attributes._validate_regex(n.get('id'),
-                                             attributes.UUID_PATTERN)
-            if res:
-                raise TypeError('Invalid input for id. Reason: %s.' % res)
-
         # NOTE(jkoelker) Get the tenant_id outside of the session to avoid
         #                unneeded db action if the operation raises
         tenant_id = self._get_tenant_id_for_create(context, p)