]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Revert "Mute neutron.callbacks notification logs."
authorIhar Hrachyshka <ihrachys@redhat.com>
Wed, 22 Jul 2015 10:53:00 +0000 (12:53 +0200)
committerIhar Hrachyshka <ihrachys@redhat.com>
Thu, 23 Jul 2015 11:49:09 +0000 (13:49 +0200)
This reverts commit e19eb49c1c066c8fa4a3c19183bca1daef553a5c.

We don't use callbacks to extend resources, so no need to mute the logs.

Change-Id: I8eaffa243f74a8f93dfc1638727ac9cd0bdf505d

neutron/callbacks/manager.py

index 8d32ff7efa36959d9c9679020923a69d11a5d76a..4927ff337f6b656300b4262388a8adbe2c2ae5af 100644 (file)
@@ -131,22 +131,14 @@ class CallbacksManager(object):
 
     def _notify_loop(self, resource, event, trigger, **kwargs):
         """The notification loop."""
-
-        #TODO(QoS): we found callback logs happening in the middle
-        #           of transactions being a source of DBDeadLocks
-        #           because they can yield. (Can LOG writes yield?,
-        #           please revisit this).
-        #
-        #LOG.debug("Notify callbacks for %(resource)s, %(event)s",
-        #          {'resource': resource, 'event': event})
+        LOG.debug("Notify callbacks for %(resource)s, %(event)s",
+                  {'resource': resource, 'event': event})
 
         errors = []
         # TODO(armax): consider using a GreenPile
         for callback_id, callback in self._callbacks[resource][event].items():
             try:
-                #TODO(QoS): muting logs for the reasons explained in the
-                #           previous TODO(QoS)
-                #LOG.debug("Calling callback %s", callback_id)
+                LOG.debug("Calling callback %s", callback_id)
                 callback(resource, event, trigger, **kwargs)
             except Exception as e:
                 LOG.exception(_LE("Error during notification for "