]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Delete test_restart_l3_agent_on_sighup
authorAssaf Muller <amuller@redhat.com>
Mon, 21 Dec 2015 22:50:36 +0000 (17:50 -0500)
committerAssaf Muller <amuller@redhat.com>
Mon, 21 Dec 2015 22:50:36 +0000 (17:50 -0500)
After looking at the test and its scope, it seems like 100% of the
code it tests is owned by oslo.service. That library has its own tests,
is there value in keeping the test in Neutron?

Change-Id: I0d8a22cc8127e183c1f55790f4b04dea2d30d356
Closes-Bug: #1518921

neutron/tests/functional/agent/test_l3_agent.py [deleted file]

diff --git a/neutron/tests/functional/agent/test_l3_agent.py b/neutron/tests/functional/agent/test_l3_agent.py
deleted file mode 100644 (file)
index 1e550f2..0000000
+++ /dev/null
@@ -1,37 +0,0 @@
-# Copyright (c) 2014 Red Hat, Inc.
-# All Rights Reserved.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License"); you may
-#    not use this file except in compliance with the License. You may obtain
-#    a copy of the License at
-#
-#         http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-#    License for the specific language governing permissions and limitations
-#    under the License.
-
-import mock
-
-from neutron.common import topics
-from neutron.tests.functional.agent.l3 import framework
-from neutron.tests.functional import test_service
-
-
-class TestL3AgentRestart(test_service.TestServiceRestart,
-                         framework.L3AgentTestFramework):
-
-    def _start_l3_agent(self, workers=1):
-        with mock.patch("neutron.service.Service.start") as start_method:
-            start_method.side_effect = self._fake_start
-            self._start_service(
-                host='agent1', binary='neutron-l3-agent',
-                topic=topics.L3_AGENT,
-                manager='neutron.agent.l3.agent.L3NATAgentWithStateReport',
-                workers=workers, conf=self.conf)
-
-    def test_restart_l3_agent_on_sighup(self):
-        self._test_restart_service_on_sighup(service=self._start_l3_agent,
-                                             workers=1)